Skip to content

Conversation

@0utplay
Copy link
Member

@0utplay 0utplay commented Jan 29, 2026

Motivation

The api supports async and sync methods but the async method currently does not delegate to the sync method of availableTemplateStoragesAsync

Modification

Added the delegation to availableTemplateStorages

Result

availableTemplateStoragesAsync works as expected

@0utplay 0utplay added this to the 4.0.0-RC17 milestone Jan 29, 2026
@0utplay 0utplay requested a review from derklaro January 29, 2026 14:52
@0utplay 0utplay self-assigned this Jan 29, 2026
@0utplay 0utplay added v: 4.X This pull should be included in the 4.0 release in: node An issue/pull request releated to the node module code labels Jan 29, 2026
@0utplay 0utplay enabled auto-merge (squash) January 29, 2026 14:52
@github-actions
Copy link

Test Results

 56 files  ±0   56 suites  ±0   4m 47s ⏱️ -8s
571 tests ±0  571 ✅ ±0  0 💤 ±0  0 ❌ ±0 
938 runs  ±0  938 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 2edeb77. ± Comparison against base commit f55b2d1.

@0utplay 0utplay merged commit 15cc106 into nightly Jan 29, 2026
5 checks passed
@0utplay 0utplay deleted the fix/template-storage-provider branch January 29, 2026 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in: node An issue/pull request releated to the node module code v: 4.X This pull should be included in the 4.0 release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants