Skip to content

Github.modified_since_commit shouldn't raise an exception if /GET to api.github.com fails #746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Buzz-Lightyear wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Github.modified_since_commit shouldn't raise an exception if /GET to api.github.com fails #746

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5ad4015
Being more specific while checking remote Cocoapods spec repo URL
Buzz-Lightyear Jun 27, 2023
4782579
Keeping the regex /github.com/ for compatibility reasons
Buzz-Lightyear Jun 27, 2023
3478cb6
If modified_since_commit fails, repo update should still continue
Buzz-Lightyear Jun 27, 2023
433fc6f
Typo in repo_id
Buzz-Lightyear Jun 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/cocoapods-core/github.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ def self.modified_since_commit(url, commit)
code = response.status_code
code != 304
rescue
raise Informative, "Failed to connect to GitHub to update the #{repo_id} specs repo - Please check if you are offline, or that GitHub is down"
puts "Failed to verify if #{repo_id} specs repo remote has been modified since commit #{commit} via /GET request to #{request_url}, continuing repo update..".yellow
end
end

Expand Down