Conversation
CodeWithEmad
force-pushed
the
feat/wordpress-instance
branch
7 times, most recently
from
bf201ae to
01fd837
Compare
regisb
left a comment
regisb
left a comment
There was a problem hiding this comment.
Mainly suggestions. Great changes overall!
|
Thank you so much, @regisb. It means a lot. I'll make sure to consider your suggestions and include them. |
CodeWithEmad
force-pushed
the
feat/wordpress-instance
branch
3 times, most recently
from
bc72207 to
77821c6
Compare
MaferMazu
left a comment
MaferMazu
left a comment
There was a problem hiding this comment.
Thanks for this PR, @CodeWithEmad; I only have a few comments, but the rest looks good to me.
Note: I only tested it in Redwood, and it works well. If something is wrong in previous versions, we can handle it in future works to bring support or drop it.
Also, I test this in dev and local, not in k8s.
| entry_points={ | ||
| "tutor.plugin.v1": [ | ||
| "wordpress = tutorwordpress.plugin" | ||
| "tutor[dev]>=15.0.0,<19.0.0", |
There was a problem hiding this comment.
Is it necessary to use tutor[dev] in a standard installation?
There was a problem hiding this comment.
This is a common pattern for tutor plugins. where we install tutor[dev], if you wnat to install tutor-contrib-wordpress[dev] for better developer experience. for example: https://github.com/overhangio/tutor-notes/blob/75e64f506597158fcd850ce76c5715acf7b0a163/setup.py#L37
There was a problem hiding this comment.
I reviewed it, and you are right; that part is not in the standard installation but in the dev mode ✨
CodeWithEmad
force-pushed
the
feat/wordpress-instance
branch
2 times, most recently
from
78d47bf to
2590a4e
Compare
|
Thank you, @MaferMazu. I did Test it in k8s. Didn't encounter any problems. |
CodeWithEmad
force-pushed
the
feat/wordpress-instance
branch
from
2590a4e to
2b26f7e
Compare
MaferMazu
left a comment
MaferMazu
left a comment
There was a problem hiding this comment.
Thanks for this @CodeWithEmad.
It looks good to me ✨
|
Thank you so much @regisb and @MaferMazu. v1.1.0 released on pypi. |
3 participants
This will add a lot of new configurations to manage a WordPress instance.
Close #4