feat(medcat-trainer): improved / fixed demo screen #293
Conversation
… clinical text component, improved demo filtering concept picker
mart-r
left a comment
mart-r
left a comment
There was a problem hiding this comment.
A few minor questions / comments.
Didn't look at the vue or ts stuff - if it displyas it displays.
Looks good overall.
| try: | ||
| cat = get_medcat_from_model_pack_id(int(modelpack_id)) | ||
| except (ValueError, TypeError): | ||
| return HttpResponseBadRequest('Invalid modelpack_id') |
There was a problem hiding this comment.
Maybe add the ID in the exception?
| except (ValueError, TypeError): | ||
| return HttpResponseBadRequest('Invalid modelpack_id') | ||
| except ModelPack.DoesNotExist: | ||
| return HttpResponseBadRequest('ModelPack does not exist') |
There was a problem hiding this comment.
Maybe add the ID in the exception?
| logger.warning(f'Failed to get children for CUI {parent_cui}: {e}') | ||
| cuis_set = expanded_cuis | ||
|
|
||
| cat.config.components.linking.filters.cuis = cuis_set |
There was a problem hiding this comment.
I guess this was always the case, but could this potentially cause issues? I.e since the same model packs instances are (potentially) used across multiple projects at once, I could see this creating unexpected filtering.
There was a problem hiding this comment.
yeah good point, fixed
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| logger.warning(f'Failed to get children for CUI {parent_cui}: {e}') | ||
| cuis_set = expanded_cuis | ||
|
|
||
| curr_cuis = cat.config.components.linking.filters |
There was a problem hiding this comment.
Perhaps a context manager would be better here?
I.e using https://docs.cogstack.org/projects/nlp/en/latest/autoapi/medcat/utils/config_utils/index.html#medcat.utils.config_utils.temp_changed_config
something like:
with temp_changed_config(cat.config.components.linking, 'filters', cuis_set):
spacy_doc = cat(message)
ClinicalTextcomponent, so entering example text and viewing the annotated version is on the same looking componentcdb_search_filterused for