Open
Conversation
…nts, changed colors of BG to variables, made the css of the form more generic.
Tamir198
requested changes
Dec 2, 2025
Member
Tamir198
left a comment
Tamir198
left a comment
There was a problem hiding this comment.
Hey left you some comment, please apply them to every place in your code
| } | ||
|
|
||
| .desk-img { | ||
| width: 22vw; |
Member
There was a problem hiding this comment.
You are mixing too many different units, pick 1 and go with it
Author
There was a problem hiding this comment.
is it ok if i'll use vw for width, vh for height and em for all the other stuff?
if not what should i use?
…, removed unwanted comment, applied all css colors as variables, combined selectors on the css file and changed the name of the div 'lower-part' to something that is not position based.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.