Open
Conversation
GilHeller
reviewed
Nov 26, 2025
| } | ||
| #submit-button{ | ||
| margin-top: 2vh; | ||
| background-color: hsl(234, 29%, 20%); |
There was a problem hiding this comment.
Use CSS variables instead of repeating colors.
:root {
--primary-dark: hsl(234, 29%, 20%);
}
....
background-color: var(--primary-dark);There was a problem hiding this comment.
consider moving index.css into the main project folder so the file structure stays clean and easier to navigate as the project grows
Comment on lines
+21
to
+23
| <p><img class="icon-picture" src="./assets/images/icon-list.svg" alt="icon-list">Product discovery and building what matters</p> | ||
| <p><img class="icon-picture" src="./assets/images/icon-list.svg" alt="icon-list">Measuring to ensure updates are a success</p> | ||
| <p><img class="icon-picture" src="./assets/images/icon-list.svg" alt="icon-list">And much more!</p> |
| <!-- Sign-up form start --> | ||
| <div id="container"> | ||
| <div class="text"> | ||
| <p id="headline">Stay updated!</p> |
There was a problem hiding this comment.
Use <h1> for your main headline instead of <p id="headline">, since it’s a page title.
| width:25vw; | ||
| display:flex; | ||
| flex-direction: column; | ||
| font-family: Roboto ,Arial; |
There was a problem hiding this comment.
consider setting a global defaults (like font-family: Roboto ,Arial; , font-weight: 400;...) using:
:root {
font-family: "Roboto", sans-serif;
....
}
GilHeller
reviewed
Nov 26, 2025
GilHeller
left a comment
GilHeller
left a comment
There was a problem hiding this comment.
Nice Job! I left you some comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'd love to get some honest review within my code