fix(client): remove the global options added by a script when it is stopped #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Sorry, I closed it by accident - it is still relevant though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, we noticed some performance issues when adding global options in our own script:
Specifically, the resource usage (observed by the resource monitor) keeps increasing after every restart of the invoking script.
After some investigation, we found that the global options added by a script are not removed when it is stopped.
This pull request properly removes global options added by scripts when they are stopped.
We had to move the definition of the
globalvariable and related api functions before theremoveResourceGlobalsfunction that is called in theonClientResourceStopevent handler so we can access the variable.