-
Notifications
You must be signed in to change notification settings - Fork 135
Add .NET 10 (preview) as the default TFM and enable multi-targeting builds #949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
4e9036e
7236d38
303a76f
c6b19fc
1e4e20d
ac50650
9441794
ef89379
e66de71
51e57ba
f3ff1ff
dc27f09
ce0d983
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,7 +6,7 @@ on: | |
| - "v*" | ||
|
|
||
| env: | ||
| DEFAULT_DOTNET_VERSION: "8.0.x" | ||
| DEFAULT_DOTNET_VERSION: "10.0.x" | ||
|
|
||
| jobs: | ||
| build: | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -24,6 +24,7 @@ jobs: | |
| dotnet-version: | | ||
| 8.0.x | ||
| 9.0.x | ||
| 10.0.x | ||
|
|
||
| - name: Get git tag | ||
| id: git_tag | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| { | ||
| "sdk": { | ||
| "allowPrerelease": false | ||
| "allowPrerelease": true | ||
| } | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -24,7 +24,7 @@ | |
| </ItemGroup> | ||
|
|
||
| <!-- Workaround for https://github.com/dotnet/aspire/issues/7779 --> | ||
| <ItemGroup Condition="'$(TargetFramework)' == 'net9.0'"> | ||
| <ItemGroup Condition="'$(TargetFramework)' == 'net9.0' or '$(TargetFramework)' == 'net10.0'"> | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Just checking, is the workaround still necessary? |
||
| <PackageReference Include="Microsoft.Extensions.Logging.Abstractions" /> | ||
| </ItemGroup> | ||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -3,7 +3,7 @@ | |||||
|
|
||||||
| <PropertyGroup> | ||||||
| <OutputType>Exe</OutputType> | ||||||
| <TargetFramework>net8.0</TargetFramework> | ||||||
| <TargetFramework>net10.0</TargetFramework> | ||||||
|
||||||
| <TargetFramework>net10.0</TargetFramework> |
Copilot
AI
Nov 11, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar to the pattern used in other AppHost projects, consider removing the explicit ImplicitUsings and Nullable properties as they are already set in Directory.Build.props (lines 11-12) and will be inherited automatically.
| <ImplicitUsings>enable</ImplicitUsings> | |
| <Nullable>enable</Nullable> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new "System" ItemGroup label lacks context for why
System.Linq.AsynchasExcludeAssetsset toallwhileSystem.Linq.AsyncEnumerableis conditionally included in specific projects. Consider adding a comment explaining thatSystem.Linq.Asyncis excluded here to avoid transitive dependencies, and thatSystem.Linq.AsyncEnumerableis conditionally referenced for .NET 8.0/9.0 only as the functionality is built-in to .NET 10.