-
Notifications
You must be signed in to change notification settings - Fork 7
CMP-3200: 🧹 upgrade golang to 1.23 #47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/retest |
|
E2E failures should be addressed in ComplianceAsCode/content#12184 |
|
/retest-required |
2 similar comments
|
/retest-required |
|
/retest-required |
|
/test e2e-aws-ocp4-moderate |
yuumasato
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
ocp4-moderate test timed out on idp remediation.
|
/test e2e-aws-ocp4-moderate |
|
Potential fix for the remediation timeout issue is available in ComplianceAsCode/content#12226 We'll likely need to land that before we can bump this dep. |
42b4181 to
9ba2390
Compare
|
Bumping the build root in openshift/release#62499 |
Let's update golang so we can keep dependencies up-to-date.
9ba2390 to
ab3c0c0
Compare
JAORMX
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
@yuumasato I'll rebase #61 on top of this PR when it lands. |
|
@rhmdnd: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
yuumasato
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
Looks like the node-compliance test still struggles to roll the updates through the nodes... |
|
From the logs it seems that the node pools are updating one after the other, can we make them update simultaneously? Anyway, bypassing the merge rules. |
Let's update golang so we can keep dependencies up-to-date.