Skip to content

Conversation

@rhmdnd
Copy link
Collaborator

@rhmdnd rhmdnd commented Jul 18, 2024

Let's update golang so we can keep dependencies up-to-date.

@Vincent056
Copy link
Collaborator

/retest

@rhmdnd
Copy link
Collaborator Author

rhmdnd commented Jul 19, 2024

E2E failures should be addressed in ComplianceAsCode/content#12184

@rhmdnd
Copy link
Collaborator Author

rhmdnd commented Jul 19, 2024

/retest-required

2 similar comments
@rhmdnd
Copy link
Collaborator Author

rhmdnd commented Jul 19, 2024

/retest-required

@Vincent056
Copy link
Collaborator

/retest-required

@rhmdnd
Copy link
Collaborator Author

rhmdnd commented Jul 23, 2024

/test e2e-aws-ocp4-moderate

Copy link
Member

@yuumasato yuumasato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

ocp4-moderate test timed out on idp remediation.

@yuumasato
Copy link
Member

/test e2e-aws-ocp4-moderate

@rhmdnd
Copy link
Collaborator Author

rhmdnd commented Jul 26, 2024

Potential fix for the remediation timeout issue is available in ComplianceAsCode/content#12226

We'll likely need to land that before we can bump this dep.

@rhmdnd rhmdnd force-pushed the update-golang-1.22 branch from 42b4181 to 9ba2390 Compare March 6, 2025 14:49
@rhmdnd rhmdnd changed the title 🧹 upgrade golang to 1.22 CMP-3200: 🧹 upgrade golang to 1.22 Mar 6, 2025
@rhmdnd
Copy link
Collaborator Author

rhmdnd commented Mar 6, 2025

Bumping the build root in openshift/release#62499

Let's update golang so we can keep dependencies up-to-date.
@rhmdnd rhmdnd changed the title CMP-3200: 🧹 upgrade golang to 1.22 CMP-3200: 🧹 upgrade golang to 1.23 Sep 22, 2025
Copy link
Collaborator

@JAORMX JAORMX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@rhmdnd
Copy link
Collaborator Author

rhmdnd commented Sep 22, 2025

@yuumasato I'll rebase #61 on top of this PR when it lands.

@openshift-ci
Copy link

openshift-ci bot commented Sep 22, 2025

@rhmdnd: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-openshift-node-compliance ab3c0c0 link true /test e2e-aws-openshift-node-compliance

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Member

@yuumasato yuumasato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@yuumasato
Copy link
Member

Looks like the node-compliance test still struggles to roll the updates through the nodes...

@yuumasato
Copy link
Member

From the logs it seems that the node pools are updating one after the other, can we make them update simultaneously?

Anyway, bypassing the merge rules.

@yuumasato yuumasato merged commit 58cd5d0 into ComplianceAsCode:main Sep 23, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants