-
Notifications
You must be signed in to change notification settings - Fork 0
[YouTrack] workflows added #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
MihaxXx
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, it looks OK.
First, fix the comments, then run yarn install and perform a prettier format for all files.
Also, please get rid of commented-out code.
YoutrackWorkflows/helper.js
Outdated
| putEmailSubject(state){ | ||
| switch (state){ | ||
| case("Done"):{ | ||
| return "Convermax - Task Completed"; | ||
| } | ||
| case("In progress"):{ | ||
| return "Convermax - Task In progress"; | ||
| } | ||
| case("New"):{ | ||
| return "Convermax - Task created"; | ||
| } | ||
| default:{ | ||
| return "Convermax - Task status updated"; | ||
| } | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about comments? I think if they deserve a specific template, they should also get a specific subject
| /** | ||
| * This is a template for an on-change rule. This rule defines what | ||
| * happens when a change is applied to an issue. | ||
| * | ||
| * For details, read the Quick Start Guide: | ||
| * https://www.jetbrains.com/help/youtrack/devportal/Quick-Start-Guide-Workflows-JS.html | ||
| */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Давай уберем эти шаблонные хедеры или заменил на название/описание фактического содержимого
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
убрать убрал, позже добавлю норм описания

SS-7545 [YouTrack] push youtrack workflow to repo
Added Youtrack workflows
