Skip to content

Conversation

@vaspfokin
Copy link

@vaspfokin vaspfokin commented Jul 10, 2025

SS-7545 [YouTrack] push youtrack workflow to repo

Added Youtrack workflows
image

  • clean code
  • add comments
  • add instructions how to use

@vaspfokin vaspfokin requested a review from MihaxXx July 10, 2025 12:11
Copy link
Contributor

@MihaxXx MihaxXx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, it looks OK.

First, fix the comments, then run yarn install and perform a prettier format for all files.
Also, please get rid of commented-out code.

Comment on lines 90 to 104
putEmailSubject(state){
switch (state){
case("Done"):{
return "Convermax - Task Completed";
}
case("In progress"):{
return "Convermax - Task In progress";
}
case("New"):{
return "Convermax - Task created";
}
default:{
return "Convermax - Task status updated";
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about comments? I think if they deserve a specific template, they should also get a specific subject

Comment on lines 1 to 7
/**
* This is a template for an on-change rule. This rule defines what
* happens when a change is applied to an issue.
*
* For details, read the Quick Start Guide:
* https://www.jetbrains.com/help/youtrack/devportal/Quick-Start-Guide-Workflows-JS.html
*/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Давай уберем эти шаблонные хедеры или заменил на название/описание фактического содержимого

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

убрать убрал, позже добавлю норм описания

@MihaxXx
Copy link
Contributor

MihaxXx commented Jul 22, 2025

@MihaxXx MihaxXx changed the title youtrack workflows added [YouTrack] workflows added Aug 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants