Skip to content

Conversation

@andrewlecuyer
Copy link
Collaborator

A new condition has been created to surface controller and node resize error condition details in the PostgresCluster status. This also allows an exclude rule for the linter to be removed.

Checklist:

  • Have you added an explanation of what your changes do and why you'd like them to be included?
  • Have you updated or added documentation for the change, as applicable?
  • Have you tested your changes on all related environments with successful results, as applicable?
    • Have you added automated tests?

Type of Changes:

  • New feature
  • Bug fix
  • Documentation
  • Testing enhancement
  • Other

What is the current behavior (link to any open issues here)?

Running the linter fails with the following:

internal/controller/postgrescluster/volumes.go:65:4: missing cases in switch of type v1.PersistentVolumeClaimConditionType: v1.PersistentVolumeClaimControllerResizeError, v1.PersistentVolumeClaimNodeResizeError (exhaustive)
                        switch condition.Type {

What is the new behavior (if this is a feature change)?

  • Breaking change (fix or feature that would cause existing functionality to change)

The linter runs successfully.

Other Information:

A new condition has been created to surface controller and node
resize error condition details in the PostgresCluster status.  This
also allows an exclude rule for the linter to be removed.
@andrewlecuyer andrewlecuyer merged commit 9f9c439 into CrunchyData:main Feb 7, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants