Definition updates and minor fixes #119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update detection-rules.json Signed-off-by: Zacgoose <[email protected]> * Update detection-rules.json Co-authored-by: Copilot <[email protected]> Signed-off-by: John Duprey <[email protected]> * Update detection-rules.json Co-authored-by: Copilot <[email protected]> Signed-off-by: John Duprey <[email protected]> * Update rules/detection-rules.json Co-authored-by: Copilot <[email protected]> Signed-off-by: Zacgoose <[email protected]> * Update detection-rules.json Signed-off-by: Zacgoose <[email protected]> --------- Signed-off-by: Zacgoose <[email protected]> Signed-off-by: John Duprey <[email protected]> Co-authored-by: KelvinTegelaar <[email protected]> Co-authored-by: John Duprey <[email protected]> Co-authored-by: Copilot <[email protected]>
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request renames the project from "ProjectX" to "Check" throughout the codebase and updates detection rules with new Microsoft domain patterns. The changes include configuration updates, documentation improvements, and pattern refinements for phishing detection.
- Updated detection rules to version 1.1.0 with enhanced regex patterns for Microsoft domains
- Renamed project from "ProjectX" to "Check" across all configuration files, URLs, and documentation
- Improved documentation formatting with standardized list styles and better spacing
Reviewed changes
Copilot reviewed 16 out of 17 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/modules/config-manager.js | Updated default custom rules URL from ProjectX to Check repository |
| rules/detection-rules.json | Bumped version to 1.1.0, added ciamlogin.com pattern, refined regex patterns for subdomains, and added powerbi.com domain |
| package.json | Renamed package from "projectx" to "Check" |
| package-lock.json | Updated package name references to "Check" |
| options/options.js | Updated default custom rules URL and added cache-first loading logic for config display |
| options/options.html | Updated placeholder URL from ProjectX to Check repository |
| enterprise/macos-linux/deploy-extension-prefs.sh | Updated default rules URL in deployment script |
| enterprise/macos-linux/check-extension-config.mobileconfig | Updated custom rules URL in mobile config |
| docs/settings/branding.md | Standardized list formatting, improved spacing, and removed "Additional Resources" section |
| docs/settings/about.md | Standardized list formatting, updated title, and added store links |
| docs/firefox-support.md | Added hidden/noIndex frontmatter, standardized list formatting throughout |
| docs/deployment/firefox-deployment.md | Added hidden/noIndex frontmatter, standardized list formatting, fixed table alignment |
| docs/deployment/chrome-edge-deployment-instructions/README.md | Updated page title and removed Firefox deployment reference |
| docs/README.md | Updated Firefox availability note, removed extra whitespace, and updated install button text |
| LICENSE | Updated copyright from ProjectX to Check |
| CHANGELOG.md | Updated repository URLs from ProjectX to Check |
| AGENTS.md | Updated title from "ProjectX Agent Guide" to "Check Agent Guide" |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]> Signed-off-by: John Duprey <[email protected]>
Co-authored-by: Copilot <[email protected]> Signed-off-by: John Duprey <[email protected]>
Co-authored-by: Copilot <[email protected]> Signed-off-by: John Duprey <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.