Skip to content

Fix aseq skipping last angle #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
champagneproblems wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix aseq skipping last angle #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
07a5fe2
Fix problem with aseq skipping last angle
champagneproblems Apr 26, 2021
cd414a1
Fix problem with aseq skipping last angle
champagneproblems Apr 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/api.f90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -388,8 +388,8 @@ subroutine aseq(a_start, a_end, n_step, &
use i_xfoil
real(c_float), intent(in) :: a_start, a_end
integer(c_int), intent(in) :: n_step
real(c_float), dimension(n_step), intent(inout) :: a_arr, cl_arr, cd_arr, cm_arr, cp_arr
logical(c_bool), dimension(n_step), intent(inout) :: conv_arr
real(c_float), dimension(n_step+1), intent(inout) :: a_arr, cl_arr, cd_arr, cm_arr, cp_arr
logical(c_bool), dimension(n_step+1), intent(inout) :: conv_arr
integer :: i, j, iseqex, itmaxs
real :: a0, da, nan

Expand All @@ -404,7 +404,7 @@ subroutine aseq(a_start, a_end, n_step, &
!----- initialize unconverged-point counter
iseqex = 0

do i=1, n_step
do i=1, n_step+1
ALFa = a0 + da * float(i - 1)
if (abs(ALFa - AWAke)>1.0E-5) LWAke = .false.
if (abs(ALFa - AVIsc)>1.0E-5) LVConv = .false.
Expand Down
16 changes: 9 additions & 7 deletions xfoil/xfoil.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
# -*- coding: utf-8 -*-
b, navigate to the main page of the repository.
Copy link
Collaborator

@daniel-de-vries daniel-de-vries Jun 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears something made it in here from your IDE. Please remove these lines.

Under your repository name, click Issues.
Click New issue.# -*- coding: utf-8 -*-
# Copyright (c) 2019 D. de Vries
#
# This file is part of XFoil.
Expand Down Expand Up @@ -257,12 +259,12 @@ def aseq(self, a_start, a_end, a_step):
"""
n = abs(int((a_end - a_start) / a_step))

a = np.zeros(n, dtype=c_float)
cl = np.zeros(n, dtype=c_float)
cd = np.zeros(n, dtype=c_float)
cm = np.zeros(n, dtype=c_float)
cp = np.zeros(n, dtype=c_float)
conv = np.zeros(n, dtype=c_bool)
a = np.zeros(n+1, dtype=c_float)
cl = np.zeros(n+1, dtype=c_float)
cd = np.zeros(n+1, dtype=c_float)
cm = np.zeros(n+1, dtype=c_float)
cp = np.zeros(n+1, dtype=c_float)
conv = np.zeros(n+1, dtype=c_bool)

self._lib.aseq(byref(c_float(a_start)), byref(c_float(a_end)), byref(c_int(n)),
a.ctypes.data_as(fptr), cl.ctypes.data_as(fptr),
Expand Down