-
Notifications
You must be signed in to change notification settings - Fork 63
Other: Move mains out off T8_EXTERN_C region
#2131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Other: Move mains out off T8_EXTERN_C region
#2131
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2131 +/- ##
=======================================
Coverage 77.95% 77.95%
=======================================
Files 113 113
Lines 19089 19089
=======================================
Hits 14881 14881
Misses 4208 4208 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I am not sure if we even need |
|
To be honest, I don't know. @sandro-elsweijer ? |
|
We sometimes build tutorials on top of each other, but with examples we don't do that. So here we can remove them pretty safely :) |
|
Removed! |
lenaploetzke
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! :)
Describe your changes here:
Noticed today while compiling t8code main using
gcc (GCC) 15.2.1 20260103All these boxes must be checked by the AUTHOR before requesting review:
Documentation:,Bugfix:,Feature:,Improvement:orOther:.All these boxes must be checked by the REVIEWERS before merging the pull request:
As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.
General
Tests
If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):
Scripts and Wiki
script/find_all_source_files.scpto check the indentation of these files.License
doc/(or already has one).