Skip to content

Conversation

@pxpeterxu
Copy link
Contributor

Motivation

Related to DMOJ/judge-server#1143:

After enabling support in judge-server for a Node.js-based executor, we need to install the pre-requisites in the Docker image used for the judge.

Changes

  • Install the latest version of Node.js on Debian using Nodesource repositories

Testing

Build image with updated Dockerfile, and ensured that Node.js was properly installed:

# Ran this on Ubuntu, but any platform with Docker installed should work
cd runtimes-docker/tier3
sudo docker build --tag=dmoj/runtimes-tier3 .
sudo docker run --entrypoint node -it dmoj/runtimes-tier3 --version
# <-- output: v20.10.0

@Xyene
Copy link
Member

Xyene commented Jan 22, 2024

This looks good to me (but we can drop the comments), thanks! Could you please also rebase to resolve the merge conflicts that have been picked up?

After that we can merge this, and CI should start passing on the judge-server PR.

@pxpeterxu
Copy link
Contributor Author

This looks good to me (but we can drop the comments), thanks! Could you please also rebase to resolve the merge conflicts that have been picked up?

After that we can merge this, and CI should start passing on the judge-server PR.

Just rebased and removed comments around adding Nodesource repository.

Copy link
Member

@Xyene Xyene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@Xyene Xyene merged commit b981e8b into DMOJ:master Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants