-
Notifications
You must be signed in to change notification settings - Fork 176
Fix Qview crashing while viewing GeoTiffs #5898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
|
The build and test suite have started for your pull request. To view your build log, please reference the build with source version: "PR_5898". Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch. |
1 similar comment
|
The build and test suite have started for your pull request. To view your build log, please reference the build with source version: "PR_5898". Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
few comments
fc11ab8 to
ce13f54
Compare
|
The build and test suite have started for your pull request. To view your build log, please reference the build with source version: "PR_5898". Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch. |
1 similar comment
|
The build and test suite have started for your pull request. To view your build log, please reference the build with source version: "PR_5898". Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch. |
f6b8818 to
2c144cb
Compare
|
The build and test suite have started for your pull request. To view your build log, please reference the build with source version: "PR_5898". Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch. |
Description
The
GdalIoHandlerhas to manage buffers requesting data outside of the image. It creates a smaller buffer, then copies the overlap back into the originally requested buffer. When working with buffers that have a scale less than 1.0, indexing into the buffer can result in going off the end of the buffer.This change unsures that the buffer cannot write off the end of the buffer when copying between scaled buffers.
Related Issue
Gdal Integration
How Has This Been Validated?
Validated through qview locally
Types of changes
Checklist:
Licensing
This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words: