-
Notifications
You must be signed in to change notification settings - Fork 176
Adds support for accessing COG shape models from STAC API #5919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The build and test suite have started for your pull request. To view your build log, please reference the build with source version: "PR_5919". Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch. |
|
The build and test suite have started for your pull request. To view your build log, please reference the build with source version: "PR_5919". Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch. |
|
Any curl requests to API Gateway within an EC2 gets blocked. It might be an issue with the VPC making it look like a private IP. So still looking into how to get around this in Codebuild (which uses an EC2). |
|
It might be best to just fake the curl call, which makes it a bit of a less usful test. We should be able to do it with C++ mocking, just more annoying than python mocking |
|
The build and test suite have started for your pull request. To view your build log, please reference the build with source version: "PR_5919". Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch. |
1 similar comment
|
The build and test suite have started for your pull request. To view your build log, please reference the build with source version: "PR_5919". Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch. |
c0d8e71 to
46bbfb9
Compare
|
The build and test suite have started for your pull request. To view your build log, please reference the build with source version: "PR_5919". Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch. |
acpaquette
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks great! One small thing to address before merge
CHANGELOG.md
Outdated
| - Added PAD or SHRINK options to crop for crops that extend beyond the source image [#5843](https://github.com/DOI-USGS/ISIS3/pull/5843) | ||
| - Added std:: namespace for isinf, fixes build errors for some versions of c++ | ||
| - Adds PROJ into ISIS, and exposes the capability with a new class called IProj. [#5317](https://github.com/DOI-USGS/ISIS3/pull/5317) | ||
| - Added support for accessing Cloud Optimized GeoTIFF (COG) shape models via STAC API |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this changelog entry get a reference to this pull request?
|
The build and test suite have started for your pull request. To view your build log, please reference the build with source version: "PR_5919". Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch. |
|
The build and test suite have started for your pull request. To view your build log, please reference the build with source version: "PR_5919". Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch. |
Description
Related Issue
Cloud ISIS Sprint
How Has This Been Validated?
Types of changes
Checklist:
Licensing
This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words: