Skip to content

Conversation

@AstroKEW78
Copy link
Contributor

@AstroKEW78 AstroKEW78 commented Dec 19, 2025

Description

Converted the legacy CameraPointInfo unit test to a GoogleTest-based test (isis/tests/CameraPointInfoTests.cpp). The new test exercises CameraPointInfo::SetImage and CameraPointInfo::SetGround using the existing unit test cube in $ISISTESTDATA, and validates expected PVL output structure by checking for required PVL keywords, basic numeric sanity (finite values), vector sizes for look-direction keywords, and broad domain bounds for latitude/longitude/angles.

Related Issue

N/A (test conversion / maintenance work)

How Has This Been Validated?

Built and executed the new GoogleTest locally in a Debug build. Ran:

  1. ctest -R CameraPointInfo --output-on-failure (includes legacy isis_unit_test_CameraPointInfo and the two new gtests)
  2. ctest -R "CameraPointInfoTest.(SetImage|SetGround)" --output-on-failure

Test data used:
$ISISTESTDATA/isis/src/base/unitTestData/CameraPointInfo/unitTest1.cub

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation change (update to the documentation; no code change)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Infrastructure change (changes to things like CI or the build system that do not impact users)

Checklist:

  • I have read and agree to abide by the Code of Conduct
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • I have added myself to the .zenodo.json document.
  • I have added my user impacting change to the CHANGELOG.md document.

Licensing

This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words:

This work is free and unencumbered software released into the public domain. In jurisdictions that recognize copyright laws, the author or authors of this software dedicate any and all copyright interest in the software to the public domain.

  • I dedicate any and all copyright interest in this software to the public domain. I make this dedication for the benefit of the public at large and to the detriment of my heirs and successors. I intend this dedication to be an overt act of relinquishment in perpetuity of all present and future rights to this software under copyright law.

@github-actions
Copy link

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5921".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

@chkim-usgs
Copy link
Contributor

Do we still need CameraPointInfo.truth and CameraPointInfo/unitTest.cpp? Looks good overall!

@github-actions
Copy link

github-actions bot commented Jan 9, 2026

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5921".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

@AstroKEW78
Copy link
Contributor Author

AstroKEW78 commented Jan 9, 2026

I have now removed the legacy CameraPointInfo/unitTest.cpp and CameraPointInfo.truth files. The CameraPointInfo coverage is now provided solely by the new gtest-based CameraPointInfoTests. The build and test suite run cleanly after this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants