Skip to content

Conversation

@aureleoules
Copy link
Member

What does this PR do?

The github.com/DataDog/datadog-agent/comp/otelcol/otlp/components/exporter/logsagentexporter package cannot be imported in the Otel collector because of this issue.

Motivation

Describe how you validated your changes

Additional Notes

@github-actions github-actions bot added the medium review PR review might take time label Nov 20, 2025
@aureleoules aureleoules added qa/done QA done before merge and regressions are covered by tests team/kubernetes-experiences changelog/no-changelog labels Nov 20, 2025
@aureleoules
Copy link
Member Author

/trigger-ci

@dd-devflow-routing-codex
Copy link

View all feedbacks in Devflow UI.

2025-11-21 08:50:30 UTC ℹ️ Start processing command /trigger-ci
If you need support, contact us on Slack #devflow!


2025-11-21 08:50:45 UTC ℹ️ Branch synced on Gitlab

Branch aurele.oules/fixup-sha-otel was out-of-sync on Gitlab - it has been resynced

If you need support, contact us on Slack #devflow!


2025-11-21 08:53:47 UTC 🚨 Devflow

Post "https://gitlab.ddbuild.io/api/v4/projects/DataDog%2Fdatadog-agent/pipeline": context deadline exceeded (Client.Timeout exceeded while awaiting headers)

Details
child workflow execution error (type: devtools.Devtools_TriggerCiFromPr, workflowID: 2cf71327-005d-4c4d-8ab4-c319a45e4ef1_36, runID: 5fc57e77-1326-4d6f-b951-894547c97bf6, initiatedEventID: 36, startedEventID: 37): child workflow execution error (type: devtools.Devtools_TriggerCi, workflowID: 5fc57e77-1326-4d6f-b951-894547c97bf6_14, runID: 57e15921-ce47-42fd-8d37-1ed5af5b1166, initiatedEventID: 14, startedEventID: 15): activity error (type: gitlab.GitlabService_CreatePipeline, scheduledEventID: 55, startedEventID: 56, identity: ): activity ScheduleToClose timeout (type: ScheduleToClose): Post "https://gitlab.ddbuild.io/api/v4/projects/DataDog%2Fdatadog-agent/pipeline": context deadline exceeded (Client.Timeout exceeded while awaiting headers) (type: Error, retryable: true): context deadline exceeded (Client.Timeout exceeded while awaiting headers) (type: timeoutError, retryable: true)

If you need support, contact us on Slack #devflow with those details!

@aureleoules
Copy link
Member Author

/merge

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Nov 21, 2025

View all feedbacks in Devflow UI.

2025-11-21 09:12:53 UTC ℹ️ Start processing command /merge


2025-11-21 09:13:00 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-11-21 10:15:10 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in main is approximately 35m (p90).


2025-11-21 11:07:51 UTC ℹ️ MergeQueue: This merge request was merged

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Nov 21, 2025

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 0b75c97

Successful checks

Info

Quality gate Delta On disk size (MiB) Delta On wire size (MiB)
agent_deb_amd64 $${0}$$ $${706.36}$$ < $${717.44}$$ $${+0.01}$$ $${172.64}$$ < $${177.37}$$
agent_deb_amd64_fips $${0}$$ $${700.63}$$ < $${711.66}$$ $${+0.01}$$ $${171.44}$$ < $${174.84}$$
agent_heroku_amd64 $${0}$$ $${328.92}$$ < $${337.57}$$ $${+0}$$ $${87.52}$$ < $${90.78}$$
agent_msi $${0}$$ $${1000.77}$$ < $${1015.38}$$ $${-0.01}$$ $${144.44}$$ < $${149.42}$$
agent_rpm_amd64 $${0}$$ $${706.34}$$ < $${717.41}$$ $${+0.02}$$ $${175.75}$$ < $${178.01}$$
agent_rpm_amd64_fips $${0}$$ $${700.61}$$ < $${711.64}$$ $${+0}$$ $${173.56}$$ < $${177.26}$$
agent_rpm_arm64 $${0}$$ $${691.63}$$ < $${702.19}$$ $${-0}$$ $${159.69}$$ < $${163.22}$$
agent_rpm_arm64_fips $${0}$$ $${687.04}$$ < $${697.6}$$ $${-0.03}$$ $${159.0}$$ < $${162.68}$$
agent_suse_amd64 $${0}$$ $${706.34}$$ < $${717.41}$$ $${+0.02}$$ $${175.75}$$ < $${178.01}$$
agent_suse_amd64_fips $${0}$$ $${700.61}$$ < $${711.64}$$ $${+0}$$ $${173.56}$$ < $${177.26}$$
agent_suse_arm64 $${0}$$ $${691.63}$$ < $${702.19}$$ $${-0}$$ $${159.69}$$ < $${163.22}$$
agent_suse_arm64_fips $${0}$$ $${687.04}$$ < $${697.6}$$ $${-0.03}$$ $${159.0}$$ < $${162.68}$$
docker_agent_amd64 $${-0}$$ $${768.74}$$ < $${769.92}$$ $${-0}$$ $${260.53}$$ < $${261.52}$$
docker_agent_arm64 $${0}$$ $${778.37}$$ < $${779.46}$$ $${+0}$$ $${250.79}$$ < $${251.72}$$
docker_agent_jmx_amd64 $${+0}$$ $${959.61}$$ < $${960.8}$$ $${+0}$$ $${329.17}$$ < $${330.15}$$
docker_agent_jmx_arm64 $${+0}$$ $${957.84}$$ < $${958.93}$$ $${-0}$$ $${315.4}$$ < $${316.35}$$
docker_cluster_agent_amd64 $${+0}$$ $${179.2}$$ < $${207.49}$$ $${+0}$$ $${63.22}$$ < $${70.2}$$
docker_cluster_agent_arm64 $${+0}$$ $${196.69}$$ < $${223.38}$$ $${+0}$$ $${59.95}$$ < $${66.42}$$
docker_cws_instrumentation_amd64 $${0}$$ $${7.07}$$ < $${7.12}$$ $${-0}$$ $${2.95}$$ < $${3.29}$$
docker_cws_instrumentation_arm64 $${0}$$ $${6.69}$$ < $${6.92}$$ $${+0}$$ $${2.7}$$ < $${3.07}$$
docker_dogstatsd_amd64 $${+0}$$ $${38.54}$$ < $${39.3}$$ $${+0}$$ $${14.9}$$ < $${15.76}$$
docker_dogstatsd_arm64 $${0}$$ $${37.18}$$ < $${37.94}$$ $${+0}$$ $${14.34}$$ < $${14.83}$$
dogstatsd_deb_amd64 $${0}$$ $${29.76}$$ < $${30.53}$$ $${-0}$$ $${7.85}$$ < $${8.75}$$
dogstatsd_deb_arm64 $${0}$$ $${28.28}$$ < $${29.11}$$ $${-0}$$ $${6.79}$$ < $${7.71}$$
dogstatsd_rpm_amd64 $${0}$$ $${29.76}$$ < $${30.53}$$ $${-0}$$ $${7.87}$$ < $${8.76}$$
dogstatsd_suse_amd64 $${0}$$ $${29.76}$$ < $${30.53}$$ $${-0}$$ $${7.87}$$ < $${8.76}$$
iot_agent_deb_amd64 $${0}$$ $${42.47}$$ < $${43.19}$$ $${-0}$$ $${11.09}$$ < $${11.98}$$
iot_agent_deb_arm64 $${0}$$ $${40.2}$$ < $${40.92}$$ $${-0}$$ $${9.54}$$ < $${10.45}$$
iot_agent_deb_armhf $${0}$$ $${40.13}$$ < $${40.86}$$ $${-0}$$ $${9.66}$$ < $${10.56}$$
iot_agent_rpm_amd64 $${0}$$ $${42.47}$$ < $${43.19}$$ $${+0}$$ $${11.1}$$ < $${12.0}$$
iot_agent_suse_amd64 $${0}$$ $${42.47}$$ < $${43.19}$$ $${+0}$$ $${11.1}$$ < $${12.0}$$

@cit-pr-commenter
Copy link

cit-pr-commenter bot commented Nov 21, 2025

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: d9d1b195-e410-4655-a55a-34f5f15167db

Baseline: 0b75c97
Comparison: 28a391c
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization +4.25 [+1.31, +7.20] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization +4.25 [+1.31, +7.20] 1 Logs
quality_gate_idle memory utilization +0.19 [+0.14, +0.24] 1 Logs bounds checks dashboard
quality_gate_idle_all_features memory utilization +0.19 [+0.14, +0.23] 1 Logs bounds checks dashboard
ddot_metrics_sum_cumulative memory utilization +0.08 [-0.07, +0.23] 1 Logs
file_tree memory utilization +0.07 [+0.02, +0.11] 1 Logs
uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization +0.02 [-0.03, +0.07] 1 Logs
ddot_metrics_sum_cumulativetodelta_exporter memory utilization +0.01 [-0.22, +0.24] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.01 [-0.11, +0.12] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.07, +0.07] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.01 [-0.42, +0.41] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.01 [-0.42, +0.39] 1 Logs
uds_dogstatsd_to_api_v3 ingress throughput -0.02 [-0.14, +0.11] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.07 [-0.12, -0.03] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.10 [-0.48, +0.27] 1 Logs
ddot_metrics memory utilization -0.15 [-0.36, +0.05] 1 Logs
tcp_syslog_to_blackhole ingress throughput -0.37 [-0.45, -0.29] 1 Logs
otlp_ingest_metrics memory utilization -0.52 [-0.66, -0.38] 1 Logs
ddot_logs memory utilization -0.53 [-0.59, -0.47] 1 Logs
docker_containers_memory memory utilization -0.53 [-0.61, -0.45] 1 Logs
ddot_metrics_sum_delta memory utilization -0.54 [-0.75, -0.34] 1 Logs
quality_gate_logs % cpu utilization -0.62 [-2.05, +0.81] 1 Logs bounds checks dashboard
quality_gate_metrics_logs memory utilization -0.91 [-1.12, -0.70] 1 Logs bounds checks dashboard
otlp_ingest_logs memory utilization -1.02 [-1.12, -0.93] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
docker_containers_cpu simple_check_run 10/10
docker_containers_memory memory_usage 10/10
docker_containers_memory simple_check_run 10/10
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency lost_bytes 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_logs memory_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 bounds checks dashboard
quality_gate_metrics_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.

@dd-mergequeue dd-mergequeue bot merged commit 3cec26b into main Nov 21, 2025
316 of 321 checks passed
@dd-mergequeue dd-mergequeue bot deleted the aurele.oules/fixup-sha-otel branch November 21, 2025 11:07
@github-actions github-actions bot added this to the 7.74.0 milestone Nov 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog medium review PR review might take time qa/done QA done before merge and regressions are covered by tests team/kubernetes-experiences

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants