Skip to content

Conversation

@dd-octo-sts
Copy link
Contributor

@dd-octo-sts dd-octo-sts bot commented Nov 20, 2025

Backport 1eaade1 from #43295.


What does this PR do?

Adds enable_retry=True to all Configuration instances used with the Datadog API client to enable automatic retry handling for HTTP 429 (rate limit) and 5xx backend errors.

Motivation

The dynamic_test-evaluate-e2e job and likely others have been intermittently failing with "Too Many Requests" errors when calling the Datadog CI Visibility API, for instance:

The datadog-api-client library has built-in retry support that automatically respects the Retry-After header on HTTP 429 responses and uses exponential backoff with sensible defaults (factor=2, max_retries=3) for other failures.

Describe how you validated your changes

  • verified that Configuration(enable_retry=True) enables automatic retry with Retry-After header handling for HTTP 429 responses,
  • applied consistently across all Datadog API client usage in the codebase.

Additional Notes

Also inlined Configuration construction for single-use cases following idiomatic Python style.

### What does this PR do?
Adds `enable_retry=True` to all `Configuration` instances used with the Datadog API client to enable automatic retry handling for HTTP 429 (rate limit) and 5xx backend errors.

### Motivation
The `dynamic_test-evaluate-e2e` job and likely others have been intermittently failing with "Too Many Requests" errors when calling the Datadog CI Visibility API, for instance:
- https://gitlab.ddbuild.io/DataDog/datadog-agent/-/jobs/1248067205
- https://gitlab.ddbuild.io/DataDog/datadog-agent/-/jobs/1247686220

The `datadog-api-client` library has built-in retry support that automatically respects the `Retry-After` header on HTTP 429 responses and uses exponential backoff with sensible defaults (`factor=2`, `max_retries=3`) for other failures.

### Describe how you validated your changes
- verified that `Configuration(enable_retry=True)` enables automatic retry with `Retry-After` header handling for HTTP 429 responses,
- applied consistently across all Datadog API client usage in the codebase.

### Additional Notes
Also inlined `Configuration` construction for single-use cases following idiomatic Python style.

Co-authored-by: regis.desgroppes <[email protected]>
(cherry picked from commit 1eaade1)
@dd-octo-sts dd-octo-sts bot requested a review from a team as a code owner November 20, 2025 18:35
@dd-octo-sts dd-octo-sts bot added changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation backport bot short review PR is simple enough to be reviewed quickly ask-review Ask required teams to review this PR labels Nov 20, 2025
@agent-platform-auto-pr
Copy link
Contributor

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 5f4276d

Successful checks

Info

Quality gate Delta On disk size (MiB) Delta On wire size (MiB)
agent_deb_amd64 DataNotFound $${695.76}$$ < $${702.15}$$ DataNotFound $${170.12}$$ < $${177.79}$$
agent_deb_amd64_fips DataNotFound $${690.1}$$ < $${696.65}$$ DataNotFound $${168.5}$$ < $${176.53}$$
agent_heroku_amd64 DataNotFound $${330.51}$$ < $${340.18}$$ DataNotFound $${87.72}$$ < $${91.08}$$
agent_msi DataNotFound $${1010.74}$$ < $${1015.38}$$ DataNotFound $${147.27}$$ < $${150.78}$$
agent_rpm_amd64 DataNotFound $${695.75}$$ < $${702.14}$$ DataNotFound $${171.97}$$ < $${180.53}$$
agent_rpm_amd64_fips DataNotFound $${690.09}$$ < $${696.64}$$ DataNotFound $${170.45}$$ < $${178.79}$$
agent_rpm_arm64 DataNotFound $${684.63}$$ < $${686.31}$$ DataNotFound $${157.83}$$ < $${161.22}$$
agent_rpm_arm64_fips DataNotFound $${680.0}$$ < $${681.84}$$ DataNotFound $${155.93}$$ < $${160.18}$$
agent_suse_amd64 DataNotFound $${695.75}$$ < $${702.14}$$ DataNotFound $${171.97}$$ < $${180.53}$$
agent_suse_amd64_fips DataNotFound $${690.09}$$ < $${696.64}$$ DataNotFound $${170.45}$$ < $${178.79}$$
agent_suse_arm64 DataNotFound $${684.63}$$ < $${686.31}$$ DataNotFound $${157.83}$$ < $${161.22}$$
agent_suse_arm64_fips DataNotFound $${680.0}$$ < $${681.84}$$ DataNotFound $${155.93}$$ < $${160.18}$$
docker_agent_amd64 DataNotFound $${748.25}$$ < $${773.59}$$ DataNotFound $${252.14}$$ < $${266.06}$$
docker_agent_arm64 DataNotFound $${761.89}$$ < $${781.7}$$ DataNotFound $${242.71}$$ < $${251.85}$$
docker_agent_jmx_amd64 DataNotFound $${939.12}$$ < $${964.45}$$ DataNotFound $${320.78}$$ < $${334.68}$$
docker_agent_jmx_arm64 DataNotFound $${941.36}$$ < $${961.17}$$ DataNotFound $${307.33}$$ < $${316.44}$$
docker_cluster_agent_amd64 DataNotFound $${206.51}$$ < $${213.74}$$ DataNotFound $${69.23}$$ < $${73.14}$$
docker_cluster_agent_arm64 DataNotFound $${222.36}$$ < $${229.68}$$ DataNotFound $${65.45}$$ < $${69.41}$$
docker_cws_instrumentation_amd64 DataNotFound $${7.07}$$ < $${7.12}$$ DataNotFound $${2.95}$$ < $${3.29}$$
docker_cws_instrumentation_arm64 DataNotFound $${6.69}$$ < $${6.92}$$ DataNotFound $${2.71}$$ < $${3.07}$$
docker_dogstatsd_amd64 DataNotFound $${38.51}$$ < $${39.3}$$ DataNotFound $${14.86}$$ < $${15.76}$$
docker_dogstatsd_arm64 DataNotFound $${37.19}$$ < $${37.94}$$ DataNotFound $${14.31}$$ < $${14.83}$$
dogstatsd_deb_amd64 DataNotFound $${29.74}$$ < $${30.53}$$ DataNotFound $${7.83}$$ < $${8.75}$$
dogstatsd_deb_arm64 DataNotFound $${28.25}$$ < $${29.11}$$ DataNotFound $${6.77}$$ < $${7.71}$$
dogstatsd_rpm_amd64 DataNotFound $${29.74}$$ < $${30.53}$$ DataNotFound $${7.84}$$ < $${8.76}$$
dogstatsd_suse_amd64 DataNotFound $${29.74}$$ < $${30.53}$$ DataNotFound $${7.84}$$ < $${8.76}$$
iot_agent_deb_amd64 DataNotFound $${42.2}$$ < $${54.97}$$ DataNotFound $${11.02}$$ < $${14.45}$$
iot_agent_deb_arm64 DataNotFound $${39.94}$$ < $${51.9}$$ DataNotFound $${9.49}$$ < $${12.63}$$
iot_agent_deb_armhf DataNotFound $${39.88}$$ < $${51.84}$$ DataNotFound $${9.6}$$ < $${12.74}$$
iot_agent_rpm_amd64 DataNotFound $${42.2}$$ < $${54.97}$$ DataNotFound $${11.03}$$ < $${14.47}$$
iot_agent_suse_amd64 DataNotFound $${42.2}$$ < $${54.97}$$ DataNotFound $${11.03}$$ < $${14.47}$$

@cit-pr-commenter
Copy link

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 7c82ee5d-9e9d-48b1-ae5a-a5393d36e751

Baseline: 4229d6d
Comparison: 69970a0
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization -38.96 [-39.98, -37.93] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_logs % cpu utilization +4.18 [+1.32, +7.04] 1 Logs bounds checks dashboard
quality_gate_metrics_logs memory utilization +1.46 [+1.22, +1.71] 1 Logs bounds checks dashboard
uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization +0.52 [+0.47, +0.58] 1 Logs
quality_gate_idle memory utilization +0.19 [+0.15, +0.23] 1 Logs bounds checks dashboard
docker_containers_memory memory utilization +0.13 [-0.38, +0.64] 1 Logs
otlp_ingest_metrics memory utilization +0.09 [-0.06, +0.24] 1 Logs
ddot_logs memory utilization +0.05 [-0.01, +0.11] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.05 [-0.54, +0.65] 1 Logs
otlp_ingest_logs memory utilization +0.05 [-0.04, +0.14] 1 Logs
ddot_metrics memory utilization +0.05 [-0.14, +0.24] 1 Logs
file_to_blackhole_1000ms_latency egress throughput +0.03 [-0.58, +0.64] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.02 [-0.21, +0.25] 1 Logs
quality_gate_idle_all_features memory utilization +0.01 [-0.03, +0.05] 1 Logs bounds checks dashboard
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.01] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.04 [-0.65, +0.57] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.07 [-0.67, +0.54] 1 Logs
ddot_metrics_sum_delta memory utilization -0.36 [-0.53, -0.19] 1 Logs
file_tree memory utilization -0.40 [-0.44, -0.35] 1 Logs
ddot_metrics_sum_cumulative memory utilization -0.56 [-0.69, -0.43] 1 Logs
ddot_metrics_sum_cumulativetodelta_exporter memory utilization -0.57 [-0.78, -0.36] 1 Logs
tcp_syslog_to_blackhole ingress throughput -1.92 [-2.00, -1.84] 1 Logs
docker_containers_cpu % cpu utilization -38.96 [-39.98, -37.93] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
docker_containers_cpu simple_check_run 10/10
docker_containers_memory memory_usage 10/10
docker_containers_memory simple_check_run 10/10
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_logs memory_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 bounds checks dashboard
quality_gate_metrics_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.

@kacper-murzyn
Copy link
Contributor

/merge

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Nov 21, 2025

View all feedbacks in Devflow UI.

2025-11-21 09:17:13 UTC ℹ️ Start processing command /merge


2025-11-21 09:17:18 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in 7.73.x is approximately 1h (p90).


2025-11-21 09:35:58 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 885cf24 into 7.73.x Nov 21, 2025
313 checks passed
@dd-mergequeue dd-mergequeue bot deleted the backport-43295-to-7.73.x branch November 21, 2025 09:35
@github-actions github-actions bot added this to the 7.73.0 milestone Nov 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ask-review Ask required teams to review this PR backport bot changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation short review PR is simple enough to be reviewed quickly

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants