Skip to content

Conversation

@andrewlock
Copy link
Member

Summary of changes

Reason for change

Implementation details

Test coverage

Other details

@andrewlock andrewlock changed the base branch from master to andrew/settings/6a-stop-using-tracer-instance November 13, 2025 17:59
@github-actions
Copy link
Contributor

Snapshots difference summary

The following differences have been observed in committed snapshots. It is meant to help the reviewer.
The diff is simplistic, so please check some files anyway while we improve it.

1 occurrences of :

-                "string_value": "unknown_service:dotnet"
+                "string_value": "Samples.OpenTelemetrySdk"

@andrewlock andrewlock force-pushed the andrew/settings/switch-up-ci-vis-initialization branch from 09d63e4 to f05a867 Compare November 13, 2025 18:03
@andrewlock andrewlock force-pushed the andrew/settings/switch-up-ci-vis-initialization branch from f05a867 to 3e1d0d0 Compare November 14, 2025 07:41
@andrewlock andrewlock force-pushed the andrew/settings/6a-stop-using-tracer-instance branch from 71c8119 to aad788e Compare November 14, 2025 07:41
@datadog-official
Copy link

datadog-official bot commented Nov 14, 2025

⚠️ Tests

⚠️ Warnings

🧪 7573 Tests failed

AzureFunctionsTests+InProcessRuntimeV4.SubmitsTraces from Datadog.Trace.ClrProfiler.IntegrationTests (Datadog)
Expected collection to contain at least 21 item(s) because we want to ensure that we don't timeout while waiting for spans from the mock tracer agent, but found 0: {empty}.
AzureFunctionsTests+IsolatedRuntimeV4AspNetCore.SubmitsTraces from Datadog.Trace.ClrProfiler.IntegrationTests (Datadog)
Expected collection to contain at least 26 item(s) because we want to ensure that we don't timeout while waiting for spans from the mock tracer agent, but found 0: {empty}.
AzureFunctionsTests+IsolatedRuntimeV4AspNetCore.SubmitsTraces from Datadog.Trace.ClrProfiler.IntegrationTests (Datadog)
Expected collection to contain at least 26 item(s) because we want to ensure that we don't timeout while waiting for spans from the mock tracer agent, but found 0: {empty}.
View all

ℹ️ Info

❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 3e1d0d0 | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@dd-trace-dotnet-ci-bot
Copy link

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing This PR (7811) and master.

✅ No regressions detected - check the details below

Full Metrics Comparison

FakeDbCommand

Metric Master (Mean ± 95% CI) Current (Mean ± 95% CI) Change Status
.NET Framework 4.8 - Baseline
duration75.17 ± (75.01 - 75.89) ms74.24 ± (73.98 - 74.74) ms-1.2%
.NET Framework 4.8 - Bailout
duration79.36 ± (79.15 - 79.86) ms80.44 ± (79.87 - 80.72) ms+1.4%✅⬆️
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration1107.51 ± (1109.26 - 1119.18) ms2964.49 ± (2964.49 - 2964.49) ms+167.7%✅⬆️
.NET Core 3.1 - Baseline
process.internal_duration_ms22.89 ± (22.81 - 22.96) ms22.79 ± (22.72 - 22.86) ms-0.4%
process.time_to_main_ms86.14 ± (85.84 - 86.43) ms86.69 ± (86.35 - 87.03) ms+0.6%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed10.92 ± (10.91 - 10.92) MB10.92 ± (10.91 - 10.92) MB-0.0%
runtime.dotnet.threads.count12 ± (12 - 12)12 ± (12 - 12)+0.0%
.NET Core 3.1 - Bailout
process.internal_duration_ms22.69 ± (22.63 - 22.76) ms22.83 ± (22.77 - 22.90) ms+0.6%✅⬆️
process.time_to_main_ms86.74 ± (86.42 - 87.07) ms87.76 ± (87.42 - 88.11) ms+1.2%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed10.95 ± (10.95 - 10.96) MB10.97 ± (10.96 - 10.97) MB+0.1%✅⬆️
runtime.dotnet.threads.count13 ± (13 - 13)13 ± (13 - 13)+0.0%
.NET 6 - Baseline
process.internal_duration_ms21.77 ± (21.70 - 21.84) ms21.64 ± (21.58 - 21.71) ms-0.6%
process.time_to_main_ms75.66 ± (75.35 - 75.98) ms75.95 ± (75.60 - 76.30) ms+0.4%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed10.60 ± (10.59 - 10.60) MB10.63 ± (10.63 - 10.63) MB+0.3%✅⬆️
runtime.dotnet.threads.count10 ± (10 - 10)10 ± (10 - 10)+0.0%
.NET 6 - Bailout
process.internal_duration_ms21.82 ± (21.76 - 21.89) ms21.64 ± (21.58 - 21.71) ms-0.8%
process.time_to_main_ms77.31 ± (76.95 - 77.67) ms77.30 ± (76.93 - 77.66) ms-0.0%
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed10.65 ± (10.64 - 10.65) MB10.66 ± (10.66 - 10.67) MB+0.2%✅⬆️
runtime.dotnet.threads.count11 ± (11 - 11)11 ± (11 - 11)+0.0%
.NET 8 - Baseline
process.internal_duration_ms19.88 ± (19.81 - 19.95) ms19.98 ± (19.91 - 20.05) ms+0.5%✅⬆️
process.time_to_main_ms75.03 ± (74.64 - 75.43) ms75.12 ± (74.79 - 75.46) ms+0.1%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed7.66 ± (7.65 - 7.67) MB7.67 ± (7.66 - 7.67) MB+0.0%✅⬆️
runtime.dotnet.threads.count10 ± (10 - 10)10 ± (10 - 10)+0.0%
.NET 8 - Bailout
process.internal_duration_ms19.92 ± (19.87 - 19.97) ms19.70 ± (19.64 - 19.75) ms-1.1%
process.time_to_main_ms76.03 ± (75.76 - 76.29) ms75.55 ± (75.25 - 75.85) ms-0.6%
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed7.71 ± (7.70 - 7.72) MB7.71 ± (7.70 - 7.71) MB-0.0%
runtime.dotnet.threads.count11 ± (11 - 11)11 ± (11 - 11)+0.0%

HttpMessageHandler

Metric Master (Mean ± 95% CI) Current (Mean ± 95% CI) Change Status
.NET Framework 4.8 - Baseline
duration192.31 ± (192.25 - 192.99) ms191.99 ± (191.94 - 192.65) ms-0.2%
.NET Framework 4.8 - Bailout
duration195.35 ± (195.10 - 195.84) ms196.76 ± (196.46 - 197.23) ms+0.7%✅⬆️
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration1162.82 ± (1161.78 - 1170.04) ms1057.57 ± (1057.57 - 1057.57) ms-9.1%
.NET Core 3.1 - Baseline
process.internal_duration_ms187.88 ± (187.46 - 188.29) ms188.36 ± (188.00 - 188.71) ms+0.3%✅⬆️
process.time_to_main_ms80.29 ± (80.12 - 80.46) ms80.57 ± (80.33 - 80.82) ms+0.3%✅⬆️
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%
runtime.dotnet.mem.committed16.06 ± (16.03 - 16.09) MB16.12 ± (16.09 - 16.15) MB+0.4%✅⬆️
runtime.dotnet.threads.count20 ± (20 - 20)20 ± (19 - 20)-0.3%
.NET Core 3.1 - Bailout
process.internal_duration_ms187.32 ± (187.01 - 187.63) ms189.33 ± (189.00 - 189.65) ms+1.1%✅⬆️
process.time_to_main_ms81.70 ± (81.55 - 81.86) ms82.20 ± (82.06 - 82.34) ms+0.6%✅⬆️
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%
runtime.dotnet.mem.committed16.11 ± (16.04 - 16.19) MB16.15 ± (16.13 - 16.18) MB+0.3%✅⬆️
runtime.dotnet.threads.count21 ± (20 - 21)21 ± (20 - 21)-0.2%
.NET 6 - Baseline
process.internal_duration_ms191.96 ± (191.59 - 192.34) ms192.91 ± (192.48 - 193.33) ms+0.5%✅⬆️
process.time_to_main_ms69.88 ± (69.67 - 70.10) ms69.90 ± (69.72 - 70.08) ms+0.0%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%
runtime.dotnet.mem.committed16.31 ± (16.24 - 16.38) MB16.24 ± (16.15 - 16.33) MB-0.5%
runtime.dotnet.threads.count19 ± (19 - 19)19 ± (19 - 19)+0.5%✅⬆️
.NET 6 - Bailout
process.internal_duration_ms191.54 ± (191.16 - 191.92) ms191.31 ± (191.03 - 191.58) ms-0.1%
process.time_to_main_ms70.76 ± (70.65 - 70.87) ms70.70 ± (70.61 - 70.80) ms-0.1%
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%
runtime.dotnet.mem.committed16.13 ± (15.98 - 16.27) MB16.33 ± (16.22 - 16.44) MB+1.3%✅⬆️
runtime.dotnet.threads.count19 ± (19 - 20)20 ± (20 - 20)+2.0%✅⬆️
.NET 8 - Baseline
process.internal_duration_ms189.18 ± (188.91 - 189.46) ms189.99 ± (189.66 - 190.32) ms+0.4%✅⬆️
process.time_to_main_ms68.83 ± (68.66 - 68.99) ms69.05 ± (68.88 - 69.22) ms+0.3%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%
runtime.dotnet.mem.committed11.72 ± (11.66 - 11.78) MB11.71 ± (11.69 - 11.74) MB-0.1%
runtime.dotnet.threads.count18 ± (17 - 18)18 ± (18 - 18)+2.7%✅⬆️
.NET 8 - Bailout
process.internal_duration_ms188.25 ± (187.97 - 188.52) ms189.26 ± (189.01 - 189.50) ms+0.5%✅⬆️
process.time_to_main_ms69.71 ± (69.61 - 69.80) ms70.05 ± (69.97 - 70.12) ms+0.5%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%
runtime.dotnet.mem.committed11.70 ± (11.61 - 11.80) MB11.71 ± (11.65 - 11.77) MB+0.1%✅⬆️
runtime.dotnet.threads.count19 ± (18 - 19)19 ± (19 - 19)+2.3%✅⬆️
Comparison explanation

Execution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

Duration charts
FakeDbCommand (.NET Framework 4.8)
gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7811) - mean (74ms)  : 68, 80
    master - mean (75ms)  : 69, 82

    section Bailout
    This PR (7811) - mean (80ms)  : 74, 87
    master - mean (80ms)  : 74, 85

    section CallTarget+Inlining+NGEN
    This PR (7811) - mean (2,964ms)  : 2964, 2964
    master - mean (1,114ms)  : 1043, 1185

Loading
FakeDbCommand (.NET Core 3.1)
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7811) - mean (117ms)  : 111, 123
    master - mean (116ms)  : 110, 123

    section Bailout
    This PR (7811) - mean (118ms)  : 111, 125
    master - mean (117ms)  : 112, 122

    section CallTarget+Inlining+NGEN
    This PR (7811) - mean (3,605ms)  : 3605, 3605
    master - mean (796ms)  : 759, 833

Loading
FakeDbCommand (.NET 6)
gantt
    title Execution time (ms) FakeDbCommand (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7811) - mean (104ms)  : 98, 110
    master - mean (104ms)  : 97, 112

    section Bailout
    This PR (7811) - mean (106ms)  : 100, 112
    master - mean (106ms)  : 98, 114

    section CallTarget+Inlining+NGEN
    This PR (7811) - mean (5,136ms)  : 5136, 5136
    master - mean (760ms)  : 717, 804

Loading
FakeDbCommand (.NET 8)
gantt
    title Execution time (ms) FakeDbCommand (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7811) - mean (103ms)  : 98, 109
    master - mean (103ms)  : 96, 110

    section Bailout
    This PR (7811) - mean (103ms)  : 97, 109
    master - mean (104ms)  : 100, 109

    section CallTarget+Inlining+NGEN
    This PR (7811) - mean (874ms)  : 874, 874
    master - mean (716ms)  : 686, 746

Loading
HttpMessageHandler (.NET Framework 4.8)
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7811) - mean (192ms)  : 189, 196
    master - mean (193ms)  : 189, 196

    section Bailout
    This PR (7811) - mean (197ms)  : 193, 201
    master - mean (195ms)  : 192, 199

    section CallTarget+Inlining+NGEN
    This PR (7811) - mean (1,058ms)  : 1058, 1058
    master - mean (1,166ms)  : 1106, 1226

Loading
HttpMessageHandler (.NET Core 3.1)
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7811) - mean (277ms)  : 272, 282
    master - mean (277ms)  : 272, 282

    section Bailout
    This PR (7811) - mean (279ms)  : 275, 284
    master - mean (277ms)  : 273, 281

    section CallTarget+Inlining+NGEN
    This PR (7811) - mean (3,495ms)  : 3495, 3495
    master - mean (949ms)  : 899, 999

Loading
HttpMessageHandler (.NET 6)
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7811) - mean (271ms)  : 265, 277
    master - mean (271ms)  : 265, 276

    section Bailout
    This PR (7811) - mean (270ms)  : 266, 274
    master - mean (270ms)  : 266, 275

    section CallTarget+Inlining+NGEN
    This PR (7811) - mean (4,048ms)  : 4048, 4048
    master - mean (926ms)  : 883, 970

Loading
HttpMessageHandler (.NET 8)
gantt
    title Execution time (ms) HttpMessageHandler (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7811) - mean (268ms)  : 264, 273
    master - mean (268ms)  : 264, 272

    section Bailout
    This PR (7811) - mean (269ms)  : 266, 272
    master - mean (267ms)  : 264, 270

    section CallTarget+Inlining+NGEN
    This PR (7811) - mean (5,175ms)  : 5175, 5175
    master - mean (853ms)  : 836, 871

Loading

@andrewlock
Copy link
Member Author

Superseded by #7821

@andrewlock andrewlock closed this Nov 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants