-
Notifications
You must be signed in to change notification settings - Fork 151
Reduce CI Vis initialization that happens when not required #7811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce CI Vis initialization that happens when not required #7811
Conversation
Snapshots difference summaryThe following differences have been observed in committed snapshots. It is meant to help the reviewer. 1 occurrences of : - "string_value": "unknown_service:dotnet"
+ "string_value": "Samples.OpenTelemetrySdk"
|
09d63e4 to
f05a867
Compare
…app startup when not in CI Visibility
f05a867 to
3e1d0d0
Compare
71c8119 to
aad788e
Compare
|
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (7811) and master. ✅ No regressions detected - check the details below Full Metrics ComparisonFakeDbCommand
HttpMessageHandler
Comparison explanationExecution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). Duration chartsFakeDbCommand (.NET Framework 4.8)gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7811) - mean (74ms) : 68, 80
master - mean (75ms) : 69, 82
section Bailout
This PR (7811) - mean (80ms) : 74, 87
master - mean (80ms) : 74, 85
section CallTarget+Inlining+NGEN
This PR (7811) - mean (2,964ms) : 2964, 2964
master - mean (1,114ms) : 1043, 1185
FakeDbCommand (.NET Core 3.1)gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7811) - mean (117ms) : 111, 123
master - mean (116ms) : 110, 123
section Bailout
This PR (7811) - mean (118ms) : 111, 125
master - mean (117ms) : 112, 122
section CallTarget+Inlining+NGEN
This PR (7811) - mean (3,605ms) : 3605, 3605
master - mean (796ms) : 759, 833
FakeDbCommand (.NET 6)gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7811) - mean (104ms) : 98, 110
master - mean (104ms) : 97, 112
section Bailout
This PR (7811) - mean (106ms) : 100, 112
master - mean (106ms) : 98, 114
section CallTarget+Inlining+NGEN
This PR (7811) - mean (5,136ms) : 5136, 5136
master - mean (760ms) : 717, 804
FakeDbCommand (.NET 8)gantt
title Execution time (ms) FakeDbCommand (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7811) - mean (103ms) : 98, 109
master - mean (103ms) : 96, 110
section Bailout
This PR (7811) - mean (103ms) : 97, 109
master - mean (104ms) : 100, 109
section CallTarget+Inlining+NGEN
This PR (7811) - mean (874ms) : 874, 874
master - mean (716ms) : 686, 746
HttpMessageHandler (.NET Framework 4.8)gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7811) - mean (192ms) : 189, 196
master - mean (193ms) : 189, 196
section Bailout
This PR (7811) - mean (197ms) : 193, 201
master - mean (195ms) : 192, 199
section CallTarget+Inlining+NGEN
This PR (7811) - mean (1,058ms) : 1058, 1058
master - mean (1,166ms) : 1106, 1226
HttpMessageHandler (.NET Core 3.1)gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7811) - mean (277ms) : 272, 282
master - mean (277ms) : 272, 282
section Bailout
This PR (7811) - mean (279ms) : 275, 284
master - mean (277ms) : 273, 281
section CallTarget+Inlining+NGEN
This PR (7811) - mean (3,495ms) : 3495, 3495
master - mean (949ms) : 899, 999
HttpMessageHandler (.NET 6)gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7811) - mean (271ms) : 265, 277
master - mean (271ms) : 265, 276
section Bailout
This PR (7811) - mean (270ms) : 266, 274
master - mean (270ms) : 266, 275
section CallTarget+Inlining+NGEN
This PR (7811) - mean (4,048ms) : 4048, 4048
master - mean (926ms) : 883, 970
HttpMessageHandler (.NET 8)gantt
title Execution time (ms) HttpMessageHandler (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7811) - mean (268ms) : 264, 273
master - mean (268ms) : 264, 272
section Bailout
This PR (7811) - mean (269ms) : 266, 272
master - mean (267ms) : 264, 270
section CallTarget+Inlining+NGEN
This PR (7811) - mean (5,175ms) : 5175, 5175
master - mean (853ms) : 836, 871
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
Superseded by #7821 |
Summary of changes
Reason for change
Implementation details
Test coverage
Other details