-
Notifications
You must be signed in to change notification settings - Fork 151
[Test Package Versions Bump] Updating package versions #7812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (7812) and master. ✅ No regressions detected - check the details below Full Metrics ComparisonFakeDbCommand
HttpMessageHandler
Comparison explanationExecution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). Duration chartsFakeDbCommand (.NET Framework 4.8)gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7812) - mean (76ms) : 71, 81
master - mean (76ms) : 71, 81
section Bailout
This PR (7812) - mean (81ms) : 75, 87
master - mean (79ms) : 76, 82
section CallTarget+Inlining+NGEN
This PR (7812) - mean (1,130ms) : 1050, 1210
master - mean (1,124ms) : 1044, 1203
FakeDbCommand (.NET Core 3.1)gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7812) - mean (119ms) : 110, 127
master - mean (117ms) : 110, 123
section Bailout
This PR (7812) - mean (119ms) : 113, 126
master - mean (119ms) : 112, 127
section CallTarget+Inlining+NGEN
This PR (7812) - mean (812ms) : 766, 858
master - mean (801ms) : 754, 847
FakeDbCommand (.NET 6)gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7812) - mean (108ms) : 101, 115
master - mean (104ms) : 98, 110
section Bailout
This PR (7812) - mean (110ms) : 102, 117
master - mean (105ms) : 100, 111
section CallTarget+Inlining+NGEN
This PR (7812) - mean (768ms) : 733, 804
master - mean (750ms) : 717, 783
FakeDbCommand (.NET 8)gantt
title Execution time (ms) FakeDbCommand (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7812) - mean (106ms) : 100, 113
master - mean (104ms) : 96, 111
section Bailout
This PR (7812) - mean (106ms) : 99, 113
master - mean (103ms) : 98, 108
section CallTarget+Inlining+NGEN
This PR (7812) - mean (733ms) : 694, 772
master - mean (716ms) : 688, 744
HttpMessageHandler (.NET Framework 4.8)gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7812) - mean (193ms) : 189, 197
master - mean (193ms) : 189, 196
section Bailout
This PR (7812) - mean (197ms) : 193, 202
master - mean (195ms) : 193, 197
section CallTarget+Inlining+NGEN
This PR (7812) - mean (1,173ms) : 1102, 1244
master - mean (1,166ms) : 1106, 1227
HttpMessageHandler (.NET Core 3.1)gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7812) - mean (282ms) : 271, 294
master - mean (277ms) : 271, 282
section Bailout
This PR (7812) - mean (284ms) : 271, 297
master - mean (277ms) : 271, 283
section CallTarget+Inlining+NGEN
This PR (7812) - mean (949ms) : 911, 986
master - mean (942ms) : 895, 988
HttpMessageHandler (.NET 6)gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7812) - mean (271ms) : 267, 276
master - mean (270ms) : 264, 276
section Bailout
This PR (7812) - mean (273ms) : 265, 280
master - mean (269ms) : 264, 274
section CallTarget+Inlining+NGEN
This PR (7812) - mean (929ms) : 879, 980
master - mean (930ms) : 877, 983
HttpMessageHandler (.NET 8)gantt
title Execution time (ms) HttpMessageHandler (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7812) - mean (269ms) : 264, 274
master - mean (268ms) : 263, 272
section Bailout
This PR (7812) - mean (270ms) : 266, 274
master - mean (268ms) : 264, 272
section CallTarget+Inlining+NGEN
This PR (7812) - mean (902ms) : 648, 1156
master - mean (855ms) : 829, 880
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
BenchmarksBenchmarks Report for benchmark platform 🐌Benchmarks for #7812 compared to master:
The following thresholds were used for comparing the benchmark speeds:
Allocation changes below 0.5% are ignored. Benchmark detailsBenchmarks.Trace.ActivityBenchmark - Same speed ✔️ More allocations
|
| Benchmark | Base Allocated | Diff Allocated | Change | Change % |
|---|---|---|---|---|
| Benchmarks.Trace.ActivityBenchmark.StartStopWithChild‑net472 | 6 KB | 6.06 KB | 52 B | 0.87% |
| Benchmark | Base Allocated | Diff Allocated | Change | Change % |
|---|---|---|---|---|
| Benchmarks.Trace.ActivityBenchmark.StartStopWithChild‑netcoreapp3.1 | 5.71 KB | 5.66 KB | -47 B | -0.82% |
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | StartStopWithChild |
net6.0 | 11.1μs | 58.5ns | 310ns | 0 | 0 | 0 | 5.51 KB |
| master | StartStopWithChild |
netcoreapp3.1 | 14μs | 62.9ns | 244ns | 0 | 0 | 0 | 5.71 KB |
| master | StartStopWithChild |
net472 | 23.4μs | 125ns | 663ns | 1.02 | 0.41 | 0.102 | 6 KB |
| #7812 | StartStopWithChild |
net6.0 | 11.2μs | 56.6ns | 260ns | 0 | 0 | 0 | 5.53 KB |
| #7812 | StartStopWithChild |
netcoreapp3.1 | 13.7μs | 70.1ns | 321ns | 0 | 0 | 0 | 5.66 KB |
| #7812 | StartStopWithChild |
net472 | 21.6μs | 108ns | 517ns | 0.972 | 0.324 | 0.108 | 6.06 KB |
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | WriteAndFlushEnrichedTraces |
net6.0 | 939μs | 44.7ns | 167ns | 0 | 0 | 0 | 2.71 KB |
| master | WriteAndFlushEnrichedTraces |
netcoreapp3.1 | 1.02ms | 144ns | 518ns | 0 | 0 | 0 | 2.7 KB |
| master | WriteAndFlushEnrichedTraces |
net472 | 1.23ms | 1.38μs | 5.36μs | 0 | 0 | 0 | 3.31 KB |
| #7812 | WriteAndFlushEnrichedTraces |
net6.0 | 934μs | 352ns | 1.36μs | 0 | 0 | 0 | 2.71 KB |
| #7812 | WriteAndFlushEnrichedTraces |
netcoreapp3.1 | 1.04ms | 77.2ns | 299ns | 0 | 0 | 0 | 2.7 KB |
| #7812 | WriteAndFlushEnrichedTraces |
net472 | 1.21ms | 747ns | 2.59μs | 0 | 0 | 0 | 3.31 KB |
Benchmarks.Trace.Asm.AppSecBodyBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | AllCycleSimpleBody |
net6.0 | 1.05μs | 5.78ns | 33.2ns | 0 | 0 | 0 | 1.22 KB |
| master | AllCycleSimpleBody |
netcoreapp3.1 | 1.46μs | 8.09ns | 54.2ns | 0 | 0 | 0 | 1.2 KB |
| master | AllCycleSimpleBody |
net472 | 1.02μs | 0.564ns | 2.18ns | 0.194 | 0 | 0 | 1.23 KB |
| master | AllCycleMoreComplexBody |
net6.0 | 6.97μs | 38.5ns | 225ns | 0 | 0 | 0 | 4.72 KB |
| master | AllCycleMoreComplexBody |
netcoreapp3.1 | 9μs | 38.1ns | 143ns | 0 | 0 | 0 | 4.62 KB |
| master | AllCycleMoreComplexBody |
net472 | 7.64μs | 2.05ns | 7.41ns | 0.726 | 0 | 0 | 4.74 KB |
| master | ObjectExtractorSimpleBody |
net6.0 | 314ns | 1.79ns | 12.9ns | 0 | 0 | 0 | 280 B |
| master | ObjectExtractorSimpleBody |
netcoreapp3.1 | 400ns | 2.26ns | 14.5ns | 0 | 0 | 0 | 272 B |
| master | ObjectExtractorSimpleBody |
net472 | 297ns | 0.0276ns | 0.103ns | 0.0434 | 0 | 0 | 281 B |
| master | ObjectExtractorMoreComplexBody |
net6.0 | 6.4μs | 27.6ns | 107ns | 0 | 0 | 0 | 3.78 KB |
| master | ObjectExtractorMoreComplexBody |
netcoreapp3.1 | 7.77μs | 35.6ns | 138ns | 0 | 0 | 0 | 3.69 KB |
| master | ObjectExtractorMoreComplexBody |
net472 | 6.75μs | 7.87ns | 30.5ns | 0.572 | 0 | 0 | 3.8 KB |
| #7812 | AllCycleSimpleBody |
net6.0 | 1.08μs | 5.92ns | 36.5ns | 0 | 0 | 0 | 1.22 KB |
| #7812 | AllCycleSimpleBody |
netcoreapp3.1 | 1.46μs | 7.19ns | 31.3ns | 0 | 0 | 0 | 1.2 KB |
| #7812 | AllCycleSimpleBody |
net472 | 1.03μs | 0.7ns | 2.71ns | 0.191 | 0 | 0 | 1.23 KB |
| #7812 | AllCycleMoreComplexBody |
net6.0 | 7.06μs | 36.7ns | 168ns | 0 | 0 | 0 | 4.72 KB |
| #7812 | AllCycleMoreComplexBody |
netcoreapp3.1 | 8.91μs | 43.8ns | 191ns | 0 | 0 | 0 | 4.62 KB |
| #7812 | AllCycleMoreComplexBody |
net472 | 7.66μs | 6.27ns | 24.3ns | 0.726 | 0 | 0 | 4.74 KB |
| #7812 | ObjectExtractorSimpleBody |
net6.0 | 313ns | 1.7ns | 9.64ns | 0 | 0 | 0 | 280 B |
| #7812 | ObjectExtractorSimpleBody |
netcoreapp3.1 | 406ns | 0.0967ns | 0.375ns | 0 | 0 | 0 | 272 B |
| #7812 | ObjectExtractorSimpleBody |
net472 | 302ns | 0.0151ns | 0.0584ns | 0.0442 | 0 | 0 | 281 B |
| #7812 | ObjectExtractorMoreComplexBody |
net6.0 | 6.28μs | 29.8ns | 111ns | 0 | 0 | 0 | 3.78 KB |
| #7812 | ObjectExtractorMoreComplexBody |
netcoreapp3.1 | 7.76μs | 39.2ns | 180ns | 0 | 0 | 0 | 3.69 KB |
| #7812 | ObjectExtractorMoreComplexBody |
net472 | 6.68μs | 2.77ns | 10.7ns | 0.571 | 0 | 0 | 3.8 KB |
Benchmarks.Trace.Asm.AppSecEncoderBenchmark - Same speed ✔️ More allocations ⚠️
More allocations ⚠️ in #7812
Benchmark
Base Allocated
Diff Allocated
Change
Change %
Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs‑net472
2.16 KB
2.17 KB
13 B
0.60%
| Benchmark | Base Allocated | Diff Allocated | Change | Change % |
|---|---|---|---|---|
| Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs‑net472 | 2.16 KB | 2.17 KB | 13 B | 0.60% |
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | EncodeArgs |
net6.0 | 79.1μs | 132ns | 512ns | 0 | 0 | 0 | 32.4 KB |
| master | EncodeArgs |
netcoreapp3.1 | 98.7μs | 130ns | 503ns | 0 | 0 | 0 | 32.4 KB |
| master | EncodeArgs |
net472 | 110μs | 11ns | 39.7ns | 4.96 | 0 | 0 | 32.51 KB |
| master | EncodeLegacyArgs |
net6.0 | 149μs | 22.4ns | 86.7ns | 0 | 0 | 0 | 2.15 KB |
| master | EncodeLegacyArgs |
netcoreapp3.1 | 198μs | 191ns | 738ns | 0 | 0 | 0 | 2.14 KB |
| master | EncodeLegacyArgs |
net472 | 264μs | 118ns | 457ns | 0 | 0 | 0 | 2.16 KB |
| #7812 | EncodeArgs |
net6.0 | 78μs | 367ns | 1.47μs | 0 | 0 | 0 | 32.4 KB |
| #7812 | EncodeArgs |
netcoreapp3.1 | 97.4μs | 266ns | 1.03μs | 0 | 0 | 0 | 32.4 KB |
| #7812 | EncodeArgs |
net472 | 109μs | 38.7ns | 150ns | 4.98 | 0 | 0 | 32.51 KB |
| #7812 | EncodeLegacyArgs |
net6.0 | 143μs | 132ns | 495ns | 0 | 0 | 0 | 2.14 KB |
| #7812 | EncodeLegacyArgs |
netcoreapp3.1 | 201μs | 307ns | 1.19μs | 0 | 0 | 0 | 2.14 KB |
| #7812 | EncodeLegacyArgs |
net472 | 266μs | 44.6ns | 173ns | 0 | 0 | 0 | 2.17 KB |
Benchmarks.Trace.Asm.AppSecWafBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | RunWafRealisticBenchmark |
net6.0 | 395μs | 63.3ns | 228ns | 0 | 0 | 0 | 4.55 KB |
| master | RunWafRealisticBenchmark |
netcoreapp3.1 | 412μs | 101ns | 377ns | 0 | 0 | 0 | 4.48 KB |
| master | RunWafRealisticBenchmark |
net472 | 429μs | 60.7ns | 227ns | 0 | 0 | 0 | 4.66 KB |
| master | RunWafRealisticBenchmarkWithAttack |
net6.0 | 285μs | 56ns | 217ns | 0 | 0 | 0 | 2.24 KB |
| master | RunWafRealisticBenchmarkWithAttack |
netcoreapp3.1 | 296μs | 455ns | 1.58μs | 0 | 0 | 0 | 2.22 KB |
| master | RunWafRealisticBenchmarkWithAttack |
net472 | 310μs | 26.7ns | 103ns | 0 | 0 | 0 | 2.29 KB |
| #7812 | RunWafRealisticBenchmark |
net6.0 | 391μs | 34.7ns | 120ns | 0 | 0 | 0 | 4.56 KB |
| #7812 | RunWafRealisticBenchmark |
netcoreapp3.1 | 412μs | 322ns | 1.16μs | 0 | 0 | 0 | 4.48 KB |
| #7812 | RunWafRealisticBenchmark |
net472 | 429μs | 37.7ns | 146ns | 0 | 0 | 0 | 4.66 KB |
| #7812 | RunWafRealisticBenchmarkWithAttack |
net6.0 | 288μs | 39.9ns | 155ns | 0 | 0 | 0 | 2.24 KB |
| #7812 | RunWafRealisticBenchmarkWithAttack |
netcoreapp3.1 | 296μs | 312ns | 1.17μs | 0 | 0 | 0 | 2.22 KB |
| #7812 | RunWafRealisticBenchmarkWithAttack |
net472 | 313μs | 30.9ns | 120ns | 0 | 0 | 0 | 2.29 KB |
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | SendRequest |
net6.0 | 62.5μs | 207ns | 800ns | 0 | 0 | 0 | 14.52 KB |
| master | SendRequest |
netcoreapp3.1 | 71.7μs | 92.6ns | 347ns | 0 | 0 | 0 | 17.42 KB |
| master | SendRequest |
net472 | 0.00731ns | 0.00202ns | 0.00782ns | 0 | 0 | 0 | 0 b |
| #7812 | SendRequest |
net6.0 | 60.6μs | 57.1ns | 213ns | 0 | 0 | 0 | 14.58 KB |
| #7812 | SendRequest |
netcoreapp3.1 | 71.5μs | 315ns | 1.37μs | 0 | 0 | 0 | 17.42 KB |
| #7812 | SendRequest |
net472 | 0.0121ns | 0.00293ns | 0.0114ns | 0 | 0 | 0 | 0 b |
Benchmarks.Trace.CharSliceBenchmark - Faster 🎉 More allocations ⚠️
Faster 🎉 in #7812
Benchmark
base/diff
Base Median (ns)
Diff Median (ns)
Modality
Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool‑net6.0
1.153
924,341.83
802,016.80
More allocations ⚠️ in #7812
Benchmark
Base Allocated
Diff Allocated
Change
Change %
Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice‑net6.0
4 B
7 B
3 B
75.00%
Fewer allocations 🎉 in #7812
Benchmark
Base Allocated
Diff Allocated
Change
Change %
Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool‑net6.0
3 B
2 B
-1 B
-33.33%
Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool‑netcoreapp3.1
1 B
0 b
-1 B
-100.00%
| Benchmark | base/diff | Base Median (ns) | Diff Median (ns) | Modality |
|---|---|---|---|---|
| Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool‑net6.0 | 1.153 | 924,341.83 | 802,016.80 |
| Benchmark | Base Allocated | Diff Allocated | Change | Change % |
|---|---|---|---|---|
| Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice‑net6.0 | 4 B | 7 B | 3 B | 75.00% |
| Benchmark | Base Allocated | Diff Allocated | Change | Change % |
|---|---|---|---|---|
| Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool‑net6.0 | 3 B | 2 B | -1 B | -33.33% |
| Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool‑netcoreapp3.1 | 1 B | 0 b | -1 B | -100.00% |
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | OriginalCharSlice |
net6.0 | 1.91ms | 3.56μs | 13.3μs | 0 | 0 | 0 | 640 KB |
| master | OriginalCharSlice |
netcoreapp3.1 | 2.14ms | 9.79μs | 39.2μs | 0 | 0 | 0 | 640 KB |
| master | OriginalCharSlice |
net472 | 2.7ms | 842ns | 3.15μs | 100 | 0 | 0 | 641.95 KB |
| master | OptimizedCharSlice |
net6.0 | 1.33ms | 377ns | 1.41μs | 0 | 0 | 0 | 4 B |
| master | OptimizedCharSlice |
netcoreapp3.1 | 1.69ms | 551ns | 2.06μs | 0 | 0 | 0 | 1 B |
| master | OptimizedCharSlice |
net472 | 1.98ms | 257ns | 962ns | 0 | 0 | 0 | 73 B |
| master | OptimizedCharSliceWithPool |
net6.0 | 924μs | 25.7ns | 99.7ns | 0 | 0 | 0 | 3 B |
| master | OptimizedCharSliceWithPool |
netcoreapp3.1 | 840μs | 133ns | 517ns | 0 | 0 | 0 | 1 B |
| master | OptimizedCharSliceWithPool |
net472 | 1.15ms | 130ns | 486ns | 0 | 0 | 0 | 47 B |
| #7812 | OriginalCharSlice |
net6.0 | 1.91ms | 968ns | 3.75μs | 0 | 0 | 0 | 640.06 KB |
| #7812 | OriginalCharSlice |
netcoreapp3.1 | 2.13ms | 9.25μs | 35.8μs | 0 | 0 | 0 | 640 KB |
| #7812 | OriginalCharSlice |
net472 | 2.58ms | 537ns | 1.94μs | 100 | 0 | 0 | 641.95 KB |
| #7812 | OptimizedCharSlice |
net6.0 | 1.44ms | 497ns | 1.92μs | 0 | 0 | 0 | 7 B |
| #7812 | OptimizedCharSlice |
netcoreapp3.1 | 1.84ms | 279ns | 1.08μs | 0 | 0 | 0 | 1 B |
| #7812 | OptimizedCharSlice |
net472 | 2.04ms | 275ns | 1.06μs | 0 | 0 | 0 | 73 B |
| #7812 | OptimizedCharSliceWithPool |
net6.0 | 802μs | 47.6ns | 184ns | 0 | 0 | 0 | 2 B |
| #7812 | OptimizedCharSliceWithPool |
netcoreapp3.1 | 848μs | 49.3ns | 191ns | 0 | 0 | 0 | 0 b |
| #7812 | OptimizedCharSliceWithPool |
net472 | 1.15ms | 110ns | 427ns | 0 | 0 | 0 | 47 B |
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | WriteAndFlushEnrichedTraces |
net6.0 | 650μs | 1.55μs | 5.79μs | 0 | 0 | 0 | 41.73 KB |
| master | WriteAndFlushEnrichedTraces |
netcoreapp3.1 | 690μs | 3.15μs | 11.8μs | 0 | 0 | 0 | 42.08 KB |
| master | WriteAndFlushEnrichedTraces |
net472 | 914μs | 4.13μs | 16μs | 8.33 | 0 | 0 | 56.42 KB |
| #7812 | WriteAndFlushEnrichedTraces |
net6.0 | 695μs | 1.05μs | 4.08μs | 0 | 0 | 0 | 41.78 KB |
| #7812 | WriteAndFlushEnrichedTraces |
netcoreapp3.1 | 634μs | 5.88μs | 58.5μs | 0 | 0 | 0 | 42.28 KB |
| #7812 | WriteAndFlushEnrichedTraces |
net472 | 853μs | 1.14μs | 4.12μs | 8.33 | 0 | 0 | 56.25 KB |
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | ExecuteNonQuery |
net6.0 | 1.92μs | 8.85ns | 31.9ns | 0 | 0 | 0 | 1.02 KB |
| master | ExecuteNonQuery |
netcoreapp3.1 | 2.68μs | 2.3ns | 8.29ns | 0 | 0 | 0 | 1.02 KB |
| master | ExecuteNonQuery |
net472 | 2.87μs | 3.69ns | 14.3ns | 0.144 | 0.0144 | 0 | 987 B |
| #7812 | ExecuteNonQuery |
net6.0 | 1.88μs | 7.37ns | 28.6ns | 0 | 0 | 0 | 1.02 KB |
| #7812 | ExecuteNonQuery |
netcoreapp3.1 | 2.63μs | 9.52ns | 36.9ns | 0 | 0 | 0 | 1.02 KB |
| #7812 | ExecuteNonQuery |
net472 | 2.78μs | 3.73ns | 14.4ns | 0.154 | 0.014 | 0 | 987 B |
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | CallElasticsearch |
net6.0 | 1.66μs | 8.35ns | 38.3ns | 0 | 0 | 0 | 1.03 KB |
| master | CallElasticsearch |
netcoreapp3.1 | 2.24μs | 1.26ns | 4.9ns | 0 | 0 | 0 | 1.03 KB |
| master | CallElasticsearch |
net472 | 3.49μs | 1.85ns | 6.94ns | 0.157 | 0 | 0 | 1.04 KB |
| master | CallElasticsearchAsync |
net6.0 | 1.86μs | 8.92ns | 35.7ns | 0 | 0 | 0 | 1.01 KB |
| master | CallElasticsearchAsync |
netcoreapp3.1 | 2.44μs | 12.2ns | 53ns | 0 | 0 | 0 | 1.08 KB |
| master | CallElasticsearchAsync |
net472 | 3.65μs | 2.93ns | 11.4ns | 0.165 | 0 | 0 | 1.1 KB |
| #7812 | CallElasticsearch |
net6.0 | 1.84μs | 7.66ns | 28.7ns | 0 | 0 | 0 | 1.03 KB |
| #7812 | CallElasticsearch |
netcoreapp3.1 | 2.22μs | 7.39ns | 28.6ns | 0 | 0 | 0 | 1.03 KB |
| #7812 | CallElasticsearch |
net472 | 3.42μs | 0.339ns | 1.22ns | 0.154 | 0 | 0 | 1.04 KB |
| #7812 | CallElasticsearchAsync |
net6.0 | 1.9μs | 1.03ns | 4ns | 0 | 0 | 0 | 1.01 KB |
| #7812 | CallElasticsearchAsync |
netcoreapp3.1 | 2.41μs | 8.28ns | 31ns | 0 | 0 | 0 | 1.08 KB |
| #7812 | CallElasticsearchAsync |
net472 | 3.59μs | 4.41ns | 17.1ns | 0.163 | 0 | 0 | 1.1 KB |
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | ExecuteAsync |
net6.0 | 1.81μs | 0.942ns | 3.65ns | 0 | 0 | 0 | 952 B |
| master | ExecuteAsync |
netcoreapp3.1 | 2.45μs | 7.74ns | 30ns | 0 | 0 | 0 | 952 B |
| master | ExecuteAsync |
net472 | 2.58μs | 0.856ns | 3.31ns | 0.141 | 0 | 0 | 915 B |
| #7812 | ExecuteAsync |
net6.0 | 1.97μs | 3.63ns | 14.1ns | 0 | 0 | 0 | 952 B |
| #7812 | ExecuteAsync |
netcoreapp3.1 | 2.44μs | 3.57ns | 13.8ns | 0 | 0 | 0 | 952 B |
| #7812 | ExecuteAsync |
net472 | 2.58μs | 1.13ns | 4.39ns | 0.142 | 0 | 0 | 915 B |
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | SendAsync |
net6.0 | 7.08μs | 3.27ns | 12.7ns | 0 | 0 | 0 | 2.36 KB |
| master | SendAsync |
netcoreapp3.1 | 8.51μs | 23.3ns | 90.4ns | 0 | 0 | 0 | 2.9 KB |
| master | SendAsync |
net472 | 12.1μs | 9.23ns | 35.7ns | 0.484 | 0 | 0 | 3.18 KB |
| #7812 | SendAsync |
net6.0 | 6.89μs | 11.7ns | 45.3ns | 0 | 0 | 0 | 2.36 KB |
| #7812 | SendAsync |
netcoreapp3.1 | 8.79μs | 23.7ns | 91.8ns | 0 | 0 | 0 | 2.9 KB |
| #7812 | SendAsync |
net472 | 12.1μs | 8.5ns | 32.9ns | 0.486 | 0 | 0 | 3.18 KB |
Benchmarks.Trace.Iast.StringAspectsBenchmark - Same speed ✔️ More allocations ⚠️
More allocations ⚠️ in #7812
Benchmark
Base Allocated
Diff Allocated
Change
Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑netcoreapp3.1
246.78 KB
275.11 KB
28.33 KB
11.48%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑netcoreapp3.1
42.92 KB
45.53 KB
2.61 KB
6.08%
Fewer allocations 🎉 in #7812
Benchmark
Base Allocated
Diff Allocated
Change
Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑net6.0
43.78 KB
43.2 KB
-576 B
-1.32%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net6.0
276.87 KB
264.82 KB
-12.06 KB
-4.35%
| Benchmark | Base Allocated | Diff Allocated | Change | Change % |
|---|---|---|---|---|
| Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑netcoreapp3.1 | 246.78 KB | 275.11 KB | 28.33 KB | 11.48% |
| Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑netcoreapp3.1 | 42.92 KB | 45.53 KB | 2.61 KB | 6.08% |
| Benchmark | Base Allocated | Diff Allocated | Change | Change % |
|---|---|---|---|---|
| Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑net6.0 | 43.78 KB | 43.2 KB | -576 B | -1.32% |
| Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net6.0 | 276.87 KB | 264.82 KB | -12.06 KB | -4.35% |
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | StringConcatBenchmark |
net6.0 | 44.6μs | 251ns | 1.57μs | 0 | 0 | 0 | 43.78 KB |
| master | StringConcatBenchmark |
netcoreapp3.1 | 48.5μs | 267ns | 2.49μs | 0 | 0 | 0 | 42.92 KB |
| master | StringConcatBenchmark |
net472 | 56.2μs | 192ns | 719ns | 0 | 0 | 0 | 57.34 KB |
| master | StringConcatAspectBenchmark |
net6.0 | 478μs | 1.95μs | 7.01μs | 0 | 0 | 0 | 276.87 KB |
| master | StringConcatAspectBenchmark |
netcoreapp3.1 | 492μs | 2.48μs | 10.8μs | 0 | 0 | 0 | 246.78 KB |
| master | StringConcatAspectBenchmark |
net472 | 403μs | 2.29μs | 16.5μs | 0 | 0 | 0 | 278.53 KB |
| #7812 | StringConcatBenchmark |
net6.0 | 49.9μs | 616ns | 6.07μs | 0 | 0 | 0 | 43.2 KB |
| #7812 | StringConcatBenchmark |
netcoreapp3.1 | 55.2μs | 662ns | 6.52μs | 0 | 0 | 0 | 45.53 KB |
| #7812 | StringConcatBenchmark |
net472 | 57.6μs | 298ns | 1.36μs | 0 | 0 | 0 | 57.34 KB |
| #7812 | StringConcatAspectBenchmark |
net6.0 | 460μs | 2.04μs | 8.89μs | 0 | 0 | 0 | 264.82 KB |
| #7812 | StringConcatAspectBenchmark |
netcoreapp3.1 | 526μs | 1.74μs | 6.03μs | 0 | 0 | 0 | 275.11 KB |
| #7812 | StringConcatAspectBenchmark |
net472 | 405μs | 2.28μs | 15.8μs | 0 | 0 | 0 | 278.53 KB |
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | EnrichedLog |
net6.0 | 2.77μs | 7.59ns | 29.4ns | 0 | 0 | 0 | 1.7 KB |
| master | EnrichedLog |
netcoreapp3.1 | 3.64μs | 12.7ns | 49.1ns | 0 | 0 | 0 | 1.7 KB |
| master | EnrichedLog |
net472 | 3.87μs | 4.24ns | 16.4ns | 0.253 | 0 | 0 | 1.64 KB |
| #7812 | EnrichedLog |
net6.0 | 2.6μs | 5.23ns | 20.3ns | 0 | 0 | 0 | 1.7 KB |
| #7812 | EnrichedLog |
netcoreapp3.1 | 3.56μs | 18.4ns | 78.1ns | 0 | 0 | 0 | 1.7 KB |
| #7812 | EnrichedLog |
net472 | 3.84μs | 5.73ns | 22.2ns | 0.249 | 0 | 0 | 1.64 KB |
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | EnrichedLog |
net6.0 | 122μs | 90.5ns | 339ns | 0 | 0 | 0 | 4.31 KB |
| master | EnrichedLog |
netcoreapp3.1 | 128μs | 140ns | 541ns | 0 | 0 | 0 | 4.31 KB |
| master | EnrichedLog |
net472 | 168μs | 125ns | 486ns | 0 | 0 | 0 | 4.52 KB |
| #7812 | EnrichedLog |
net6.0 | 123μs | 198ns | 686ns | 0 | 0 | 0 | 4.31 KB |
| #7812 | EnrichedLog |
netcoreapp3.1 | 128μs | 170ns | 638ns | 0 | 0 | 0 | 4.31 KB |
| #7812 | EnrichedLog |
net472 | 166μs | 60ns | 232ns | 0 | 0 | 0 | 4.51 KB |
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | EnrichedLog |
net6.0 | 4.93μs | 14ns | 54.4ns | 0 | 0 | 0 | 2.26 KB |
| master | EnrichedLog |
netcoreapp3.1 | 6.7μs | 21ns | 81.3ns | 0 | 0 | 0 | 2.26 KB |
| master | EnrichedLog |
net472 | 7.62μs | 7.71ns | 29.9ns | 0.303 | 0 | 0 | 2.08 KB |
| #7812 | EnrichedLog |
net6.0 | 4.89μs | 7.27ns | 27.2ns | 0 | 0 | 0 | 2.26 KB |
| #7812 | EnrichedLog |
netcoreapp3.1 | 6.91μs | 15.3ns | 59.1ns | 0 | 0 | 0 | 2.26 KB |
| #7812 | EnrichedLog |
net472 | 7.52μs | 10.3ns | 40ns | 0.3 | 0 | 0 | 2.08 KB |
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | SendReceive |
net6.0 | 2.09μs | 3.88ns | 15ns | 0 | 0 | 0 | 1.2 KB |
| master | SendReceive |
netcoreapp3.1 | 2.57μs | 12.2ns | 50.2ns | 0 | 0 | 0 | 1.2 KB |
| master | SendReceive |
net472 | 3.13μs | 6.92ns | 26.8ns | 0.189 | 0 | 0 | 1.2 KB |
| #7812 | SendReceive |
net6.0 | 1.96μs | 10.1ns | 49.7ns | 0 | 0 | 0 | 1.2 KB |
| #7812 | SendReceive |
netcoreapp3.1 | 2.5μs | 12.5ns | 53.2ns | 0 | 0 | 0 | 1.2 KB |
| #7812 | SendReceive |
net472 | 3.05μs | 4.27ns | 16.6ns | 0.185 | 0 | 0 | 1.2 KB |
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | EnrichedLog |
net6.0 | 4.43μs | 3.32ns | 12.9ns | 0 | 0 | 0 | 1.58 KB |
| master | EnrichedLog |
netcoreapp3.1 | 5.62μs | 17.2ns | 64.4ns | 0 | 0 | 0 | 1.63 KB |
| master | EnrichedLog |
net472 | 6.67μs | 6.64ns | 23.9ns | 0.296 | 0 | 0 | 2.03 KB |
| #7812 | EnrichedLog |
net6.0 | 4.2μs | 2.29ns | 7.94ns | 0 | 0 | 0 | 1.58 KB |
| #7812 | EnrichedLog |
netcoreapp3.1 | 5.49μs | 25.3ns | 97.8ns | 0 | 0 | 0 | 1.63 KB |
| #7812 | EnrichedLog |
net472 | 6.64μs | 8.15ns | 31.6ns | 0.297 | 0 | 0 | 2.03 KB |
Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | StartFinishSpan |
net6.0 | 789ns | 3.75ns | 15ns | 0 | 0 | 0 | 576 B |
| master | StartFinishSpan |
netcoreapp3.1 | 965ns | 4.87ns | 23.4ns | 0 | 0 | 0 | 576 B |
| master | StartFinishSpan |
net472 | 949ns | 0.0512ns | 0.185ns | 0.0901 | 0 | 0 | 578 B |
| master | StartFinishScope |
net6.0 | 946ns | 0.629ns | 2.44ns | 0 | 0 | 0 | 696 B |
| master | StartFinishScope |
netcoreapp3.1 | 1.22μs | 2.96ns | 11.5ns | 0 | 0 | 0 | 696 B |
| master | StartFinishScope |
net472 | 1.13μs | 0.288ns | 1.04ns | 0.102 | 0 | 0 | 658 B |
| #7812 | StartFinishSpan |
net6.0 | 766ns | 3.31ns | 12.8ns | 0 | 0 | 0 | 576 B |
| #7812 | StartFinishSpan |
netcoreapp3.1 | 982ns | 5.26ns | 27.3ns | 0 | 0 | 0 | 576 B |
| #7812 | StartFinishSpan |
net472 | 942ns | 0.384ns | 1.44ns | 0.0898 | 0 | 0 | 578 B |
| #7812 | StartFinishScope |
net6.0 | 921ns | 4.79ns | 22.5ns | 0 | 0 | 0 | 696 B |
| #7812 | StartFinishScope |
netcoreapp3.1 | 1.22μs | 6.05ns | 26.4ns | 0 | 0 | 0 | 696 B |
| #7812 | StartFinishScope |
net472 | 1.14μs | 0.281ns | 1.01ns | 0.0992 | 0 | 0 | 658 B |
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | RunOnMethodBegin |
net6.0 | 1.07μs | 5.24ns | 20.9ns | 0 | 0 | 0 | 696 B |
| master | RunOnMethodBegin |
netcoreapp3.1 | 1.44μs | 0.635ns | 2.46ns | 0 | 0 | 0 | 696 B |
| master | RunOnMethodBegin |
net472 | 1.45μs | 1.29ns | 4.99ns | 0.101 | 0 | 0 | 658 B |
| #7812 | RunOnMethodBegin |
net6.0 | 1.06μs | 5.34ns | 23.9ns | 0 | 0 | 0 | 696 B |
| #7812 | RunOnMethodBegin |
netcoreapp3.1 | 1.42μs | 6.8ns | 27.2ns | 0 | 0 | 0 | 696 B |
| #7812 | RunOnMethodBegin |
net472 | 1.43μs | 0.513ns | 1.92ns | 0.0998 | 0 | 0 | 658 B |
andrewlock
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as it all passes! One package needs a manual bump, I'll do that in a separate PR
| <!-- Assembly: Microsoft.Extensions.Telemetry --> | ||
| <!-- Latest package https://www.nuget.org/packages/Microsoft.Extensions.Telemetry/9.10.0 --> | ||
| <!-- Latest package https://www.nuget.org/packages/Microsoft.Extensions.Telemetry/10.0.0 --> | ||
| <PackageReference Include="Microsoft.Extensions.Telemetry" Version="9.10.0" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs bumping
Updates the package versions for integration tests.