Skip to content

Conversation

@rachelyangdog
Copy link
Contributor

What does this PR do?

Motivation

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running ./scripts/lint.sh locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@rachelyangdog rachelyangdog requested a review from a team as a code owner November 17, 2025 21:08
@rachelyangdog rachelyangdog marked this pull request as draft November 17, 2025 21:08
@pr-commenter
Copy link

pr-commenter bot commented Nov 17, 2025

Benchmarks

Benchmark execution time: 2025-11-18 22:43:58

Comparing candidate commit ee1546c in PR branch rachel.yang/otel-metrics with baseline commit a1926ab in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics.

@datadog-official
Copy link
Contributor

datadog-official bot commented Nov 18, 2025

⚠️ Tests

⚠️ Warnings

❄️ 2 New flaky tests detected

TestSamplingDecision from github.com/DataDog/dd-trace-go/v2/ddtrace/tracer (Datadog)
Failed

=== RUN   TestSamplingDecision
--- FAIL: TestSamplingDecision (0.06s)
TestSamplingDecision/single_spans_without_max_per_second:rate_0.5 from github.com/DataDog/dd-trace-go/v2/ddtrace/tracer (Datadog)
Failed

=== RUN   TestSamplingDecision/single_spans_without_max_per_second:rate_0.5
    tracer_test.go:731: 
        	Error Trace:	/Users/runner/work/dd-trace-go/dd-trace-go/ddtrace/tracer/tracer_test.go:731
        	Error:      	Max difference between 0.8 and 0.65 allowed is 0.15, but difference was 0.15000000000000002
        	Test:       	TestSamplingDecision/single_spans_without_max_per_second:rate_0.5
    --- FAIL: TestSamplingDecision/single_spans_without_max_per_second:rate_0.5 (0.01s)

ℹ️ Info

🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: ee1546c | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@rachelyangdog rachelyangdog changed the title WIP: testing otel metrics WIP: feat(otel): adding support for OpenTelemetry metrics Nov 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants