[Versioning] Rename ddcommon and ddcommon-ffi #1314
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
profiling
iunanua
force-pushed
the
igor/versioning/libdd-common
branch
from
ac1e95b to
70b1c65
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1314 +/- ##
==========================================
- Coverage 71.66% 71.60% -0.06%
==========================================
Files 370 370
Lines 58581 58578 -3
==========================================
- Hits 41984 41947 -37
- Misses 16597 16631 +34
🚀 New features to boost your workflow:
|
BenchmarksComparisonBenchmark execution time: 2025-11-07 18:23:24 Comparing candidate commit 49bb9d1 in PR branch Found 9 performance improvements and 2 performance regressions! Performance is the same for 44 metrics, 2 unstable metrics. scenario:benching serializing traces from their internal representation to msgpack
scenario:credit_card/is_card_number/378282246310005
scenario:credit_card/is_card_number/37828224631000521389798
scenario:credit_card/is_card_number_no_luhn/ 378282246310005
scenario:credit_card/is_card_number_no_luhn/378282246310005
scenario:credit_card/is_card_number_no_luhn/37828224631000521389798
CandidateCandidate benchmark detailsGroup 1
Group 2
Group 3
Group 4
Group 5
Group 6
Group 7
Group 8
Group 9
Group 10
Group 11
Group 12
Group 13
Group 14
Group 15
Group 16
Group 17
BaselineOmitted due to size. |
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-unknown-linux-gnu
|
ekump
reviewed
Nov 6, 2025
data-pipeline/Cargo.toml
Outdated
| tokio-util = "0.7.11" | ||
|
|
||
| ddcommon = { path = "../ddcommon", default-features = false } | ||
| ddcommon = { version = "1.0.0", path = "../libdd-common", package = "libdd-common", default-features = false } |
Contributor
There was a problem hiding this comment.
shouldn't this be libdd-common? Why call it ddocommon and have package = "libdd-common"?
Contributor
There was a problem hiding this comment.
I pushed a commit that imports the package as libdd-common and updated all the use statements. Unless we have good reason, we should get all the changes done in one go. Feel free to drop the commit if it's truly a bad idea. CC @hoolioh
Contributor
Author
There was a problem hiding this comment.
the idea was to use the alias to reduce the changes of this PR and update the use statements in the following PRs where the alias has been used.
But there is no problem if you have changed them.
I don't think there are many conflicts these days.
Contributor
There was a problem hiding this comment.
The reasoning behind using the alias was to reduce the scope of the PR and defer the code changes for the PR that renames data-pipeline. That said I don´t think it's a bad idea and since we know people in data-pipeline we can get their approvals for the files they own :).
morrisonlevi
approved these changes
Nov 7, 2025
Contributor
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
dd-devflow
bot
added
mergequeue-status: queued
mergequeue-status: in_progress
and removed
mergequeue-status: queued
labels
dd-devflow
bot
added
mergequeue-status: done
and removed
mergequeue-status: in_progress
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
A brief description of the change being made with this pull request.
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
How to test the change?
Describe here in detail how the change can be validated.