-
Notifications
You must be signed in to change notification settings - Fork 6.7k
add: add partial support for EVO DEX on supra #16941
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The adapter at projects/evo exports TVL: |
projects/evo/index.js
Outdated
| ); | ||
| return result[0]; | ||
| } catch (error) { | ||
| console.error(`Error fetching data for pool ${poolId}: ${error.message}`); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please no try catch and please remove any console logs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay I get that, they were left on purpose as instructed on Discord. Would you already have FA support so I can run the test again on my end and confirm TVL is showing correctly?
Will remove the try and console lgos as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you link me to the message? What is FA? You can test using node test.js <path to adapter>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The conversation we had on Discord is linked within the original PR under Important information. It also states what the "issue" is with the adapter and why it is posted like that.
Supra is a Aptos-based blockchain, where there are multiple type of assets. In the above mentioned section, the "coreAssets.json" which is likely used to compute prices is only supporting the "Legacy" version of Supra (chain's base currency); The DEX is using the "Fungible Asset" version.
I was also aware of the test command, since that is also mentioned within my section and what the result/issue is.
Useful links:
Supra Fungible Asset
Aptos Legacy Coin
Aptos Fungible Asset
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the FA address for SUPRA? Can you add it to coreAssets.json as SUPRA_1 or something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
|
The adapter at projects/evo exports TVL: |
|
The adapter at projects/evo exports TVL: |
|
Is this result expected? |
No this is incorrect. The current TVL of EVO is $892. This is broken down as follows: supUSDC-supUSDT:
SUPRA-supUSDC:
SUPRA-supUSDT:
Our front-end is available at: https://app.evo.market/pools |
|
We dont have pricing for Supra Wrapped USDC or USDT, where are these bridged from? What backs them? |
DEX Information
Name (to be shown on DefiLlama): EVO
Twitter Link: https://x.com/TradeWithEvo
List of audit links if any: Audit is pending
Website Link: https://app.evo.market
Logo (High resolution, will be shown with rounded borders): https://app.evo.market
Current TVL: $900
Treasury Addresses (if the protocol has treasury): 0xf2340c2c40896c9cb8c9ac0b929b84d8ad5f4811f4c0171cacc44f7ca1c9b43b
Chain: Supra
Coingecko ID (so your TVL can appear on Coingecko, leave empty if not listed): - (pending listing)
Coinmarketcap ID (so your TVL can appear on Coinmarketcap, leave empty if not listed): -
Short Description (to be shown on DefiLlama): EVO is a native Concentrated Liquidity Market Maker on Supra.
Token address and ticker if any: -
Category (full list at https://defillama.com/categories) *Please choose only one: DEX
Oracle Provider(s): Specify the oracle(s) used (e.g., Chainlink, Band, API3, TWAP, etc.): -
Implementation Details: Briefly describe how the oracle is integrated into your project: -
Documentation/Proof: Provide links to documentation or any other resources that verify the oracle's usage: -
forkedFrom (Does your project originate from another project): -
methodology (what is being counted as tvl, how is tvl being calculated): -
Github org/user (Optional, if your code is open source, we can track activity): https://github.com/orgs/EvoMarket
Important information
I've been instructed by realShaman on the Discord server to post the PR as it is.
This adapter is partly implemented, because within DeFiLlama's Supra support, only Legacy Supra is tracked and our DEX is only using FA Supra.
I specifically left off the console.log used for development, to aid in fully supporting our protocol, revealed in the test.js comman.
node test.js projects/evo/index.js