Skip to content

Conversation

@deevdevil88
Copy link
Contributor

mino types in the count_mtric

mino types in the count_mtric
@bio-la
Copy link
Collaborator

bio-la commented Jan 8, 2024

hi @deevdevil88, thanks for starting this PR.
we need more testing on this feature to ensure we can deal with different cellranger versions outputs.
in particular your suggested modification to the summary column conversion will break the current working version, which is why we need to clearly deal with cellranger-version dependencies.
see

def parse_10x_cellranger_multi(path_df,path_col='metrics_summary_path'):

can you fix this? thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants