Add lowmem parameter to MOFA #311
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I think as additional improvements it would be worth to print number of features in every mod used by MOFA in the logging info - easier to troubleshoot |
bio-la
approved these changes
Sep 4, 2024
Collaborator
|
@wlason this seems to work fine, i would just like you to add a new CI to test the lowmem parameter for MOFA. |
deevdevil88
reviewed
Sep 4, 2024
deevdevil88
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves #308
lowmemoption tobatch_correct_mofa.py, which recalculates ATAC HVFs, keeping just top 25klowmemto the integration YAMLfilter_by_hvgin YAML is set to anything other thanTrue(filter_by_hvgwas erroneously passed tomu.tl.mofakwargs)