Skip to content

Conversation

@wlason
Copy link
Contributor

@wlason wlason commented Nov 6, 2024

I found further problems with the defaults in calc_proportions.

  • I updated the old defaults in run_scanpyQC_rna.py from "mitochondrial,ribosomal" to None
  • Added the if-statement to not process the calc_proportion string if it is not passed
  • Added the new defaults consistent with qc_genelist_1.0.csv to the ingest yaml

@wlason wlason requested review from bio-la and deevdevil88 November 6, 2024 17:24
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch @wlason setting None in the python script will kick in if nothing is specified in the pipeline.yml. (current default in the pipeline.yml is MarkersNeutro but the change you have introduced ensures that None is the intended parameter)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants