Skip to content

better fix for the playwright hanging issues #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 20, 2025
Merged

better fix for the playwright hanging issues #54

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c852b6e
better fix for the playwright hanging issues
DetachHead Jul 2, 2025
e2f03be
bump the ui5 version used by unit tests since 1.125 was deleted from …
DetachHead Oct 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 2 additions & 12 deletions src/node/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,18 +7,8 @@ export type SelectorEngine = Parameters<typeof selectors.register>[1]
const selectorEngine = (fileName: string): SelectorEngine => ({
// https://github.com/microsoft/playwright/issues/36448
content: `(() => {
const useFakeModule = typeof module === 'undefined'
if (useFakeModule) {
window.module = {exports: {}};
}
try {
${readFileSync(join(__dirname, `../../dist/browser/${fileName}.js`), 'utf8')};
return module.exports.default
} finally {
if (useFakeModule) {
delete module
}
}
const module = {exports: {}};
${readFileSync(join(__dirname, `../../dist/browser/${fileName}.js`), 'utf8')};
return module.exports.default
})()`,
})
Expand Down
2 changes: 1 addition & 1 deletion tests/testUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ export class Ui5Tester {
this.selectorEngineId = `ui5_${selectorEngineName}`
}
navigateToUi5DocsPage = async (page: Page, path: `/${string}`) => {
await page.goto(`https://ui5.sap.com/1.125.1${path}`)
await page.goto(`https://ui5.sap.com/1.127.7${path}`)
await page.waitForSelector(
`${this.selectorEngineId}=${
this.selectorEngineName === 'css' ? '*' : '//*'
Expand Down
Loading