-
-
Notifications
You must be signed in to change notification settings - Fork 237
Duplication action GA #752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: templates
Are you sure you want to change the base?
Conversation
GA that checks for phrases like windows defender and virus and then posts duplicates
See wordsOlder threads had words like this; should probably add some of those? |
|
Hmmmmmm. I'd still like to prevent having issues like this filed in the first place, instead of closing already-made ones. I came up with this yesterday, before your PR suggestion: 6913657 It's a little bit passive-aggressive, but it's kinda intentional, otherwise people would submit it anyway. What are your thoughts on it? |
|
I vote for issue template, but I think yours is too long? People will just skip reading it |
|
why not both? if someone skips over reading and making it, it'll force them
with a comment?
…On Wed, Aug 20, 2025 at 8:48 AM Joakim Hellsén ***@***.***> wrote:
*TheLovinator1* left a comment (DevilXD/TwitchDropsMiner#752)
<#752 (comment)>
I vote for issue template, but I think yours is too long? People will just
skip reading it
—
Reply to this email directly, view it on GitHub
<#752 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEGOWNCXXWXVPJ2FOHSIU3D3ORVBLAVCNFSM6AAAAACEJ46GS6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTEMBWGE4TKNZTGI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
@TheLovinator1 The point is that you can't just skip over it, because the checkboxes at the end are marked as required, so they'd have to select all three options to proceed anyway. I'm assuming they're at least that smart enough to read what they're selecting, but maybe that's a wrong assumption. @secretsoup Hmm. Both sounds interesting, but I kinda feel like this may trigger false-positives, especially if we'd to expand the words it looks for. Does this close the issue it replies to, or just comments under it? Does it re-check every further comment under the issue too? |
|
It just adds a comment. It can auto-close it or tag it but I didn't know if
that'd be too aggressive in case of an actual issue.
…On Wed, Aug 20, 2025 at 12:04 PM DevilXD ***@***.***> wrote:
*DevilXD* left a comment (DevilXD/TwitchDropsMiner#752)
<#752 (comment)>
@TheLovinator1 <https://github.com/TheLovinator1> The point is that you
can't just skip over it, because the checkboxes at the end are marked as
required, so they'd have to select all three options to proceed anyway. I'm
assuming they're at least that smart enough to read what they're selecting,
but maybe that's a wrong assumption.
@secretsoup <https://github.com/secretsoup> Hmm. Both sounds interesting,
but I kinda feel like this may trigger false-positives, especially if we'd
to expand the words it looks for. Does this close the issue it replies to,
or just comments under it? Does it re-check every further comment under the
issue too?
—
Reply to this email directly, view it on GitHub
<#752 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEGOWND5NQITTIL7GVXNVW33OSL7PAVCNFSM6AAAAACEJ46GS6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTEMBXGAYDGNZZGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Hmm. Just a comment should be benign enough, I guess. |
I can tell you now that making the assumption that people are at least smart enough to read stuff they are selecting is not a good assumption to make, time and time again I have been proven wrong and that people will just click things without even reading said things. |
Co-authored-by: DevilXD <[email protected]>
|
I can merge it like this, but it'll only officially go live when the EDIT: Deleted some offtopic comments below. |
GA that checks for phrases like windows defender and virus and then posts duplicates. Let me know if you want to add additional keywords, modify phrases or auto-tag it as a duplicate/auto-close.