feat(cliprdr): add request_file_contents method #1065
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The server uses `ironrdp_tokio::reqwest::ReqwestNetworkClient` in accept_credssp but the reqwest feature was not enabled, causing compilation to fail. Fixes Devolutions#1062
glamberson
force-pushed
the
pr2-request-file-contents
branch
from
950c8d8 to
421d3e5
Compare
Per MS-RDPECLIP sections 2.2.4.6 and 2.2.4.7, the Local Clipboard Owner may lock the Shared Clipboard Owner's clipboard data before requesting file contents. This ensures data stability during multi-request file transfers. Adds lock_clipboard() and unlock_clipboard() methods with corresponding ClipboardMessage variants for server integration.
Per MS-RDPECLIP section 2.2.5.3, the Local Clipboard Owner sends File Contents Request PDU to retrieve file data from the Shared Clipboard Owner. This enables server-side file paste operations. Adds request_file_contents() method with SendFileContentsRequest message variant for server integration.
glamberson
force-pushed
the
pr2-request-file-contents
branch
from
421d3e5 to
4ff56cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per MS-RDPECLIP section 2.2.5.3, the Local Clipboard Owner
sends File Contents Request PDU to retrieve file data from the Shared Clipboard
Owner during paste operations.
This enables server implementations to request file contents from clients,
completing the bidirectional file transfer capability.
Changes
SendFileContentsRequestmessage variant inClipboardMessagerequest_file_contents()method onCliprdr<R>Dependencies
Depends on #1064 (lock/unlock methods).