Skip to content

add support for version of doc upload which accepts bucket and JSON key #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nick-j-roberts wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add support for version of doc upload which accepts bucket and JSON key #39

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions stormcloud/ms/upload_documents.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,9 @@ def _sanitize(input_str: str) -> str:


def get_ranked_docs(bucket: str, s3_client: Any, **kwargs) -> Iterator[dict]:
json_key = construct_key(**kwargs)
json_key = kwargs.get("json_key", None)
if json_key == None:
json_key = construct_key(**kwargs)
logging.info(f"getting ranked document information from s3://{bucket}/{json_key}")
res = s3_client.get_object(Bucket=bucket, Key=json_key)
text = res.get("Body").read().decode()
Expand All @@ -114,7 +116,7 @@ def __enter__(self):

def __exit__(self, *args) -> None:
self.handle_queue()
non_null_args = [a for a in filter(args)]
non_null_args = [a for a in filter(None, args)]
if len(non_null_args) > 0:
logging.error(f"exited with error message: {', '.join(non_null_args)}")

Expand Down Expand Up @@ -153,9 +155,9 @@ def main(ms_client: Client, s3_client: Any, index: str, s3_bucket: str, update:
import argparse
import os

from dotenv import load_dotenv
from client_utils import create_meilisearch_client, create_s3_client
from constants import INDEX
from dotenv import load_dotenv

load_dotenv("stormcloud/ms/.env")

Expand Down