Skip to content

[Fix] review v2 UI 수정사항 반영 #430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HI-JIN2 merged 6 commits into from
Dec 23, 2025
Merged

[Fix] review v2 UI 수정사항 반영 #430

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7ca6b6d
chore: 엄지척 아이콘 사이즈 12.dp
HI-JIN2 Dec 21, 2025
07629ec
chore: 오늘의 메뉴 옆 아이콘 크기 조정
HI-JIN2 Dec 21, 2025
2bafaf9
chore: 리뷰관리 점3개버튼과 작성일 끝점 맞춤
HI-JIN2 Dec 21, 2025
d27bbd7
chore: 리뷰관리 점3개버튼과 작성일 끝점 맞춤
HI-JIN2 Dec 21, 2025
52b9e72
Merge remote-tracking branch 'origin/fix/review-v2-ui' into fix/revie…
HI-JIN2 Dec 21, 2025
b0225bf
chore: 리뷰관리 점3개버튼과 작성일 끝점 맞춤
HI-JIN2 Dec 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions app/src/main/java/com/eatssu/android/presentation/cafeteria/review/list/ReviewListScreen.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,10 +354,12 @@ fun ReviewInfoContent(
modifier = Modifier.fillMaxWidth(),
horizontalAlignment = Alignment.CenterHorizontally
) {
Row {
Row(
verticalAlignment = Alignment.CenterVertically
) {
Icon(
painter = painterResource(R.drawable.ic_cafeteria_menu_selected),
modifier = Modifier.size(24.dp),
modifier = Modifier.size(18.dp),
tint = Primary,
contentDescription = "map restaurant icon"
)
Expand Down
27 changes: 20 additions & 7 deletions ...c/main/java/com/eatssu/android/presentation/cafeteria/review/list/component/ReviewItem.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,24 @@
package com.eatssu.android.presentation.cafeteria.review.list.component

import androidx.compose.foundation.clickable
import androidx.compose.foundation.interaction.MutableInteractionSource
import androidx.compose.foundation.layout.Arrangement
import androidx.compose.foundation.layout.Box
import androidx.compose.foundation.layout.Column
import androidx.compose.foundation.layout.FlowRow
import androidx.compose.foundation.layout.Row
import androidx.compose.foundation.layout.Spacer
import androidx.compose.foundation.layout.fillMaxWidth
import androidx.compose.foundation.layout.height
import androidx.compose.foundation.layout.offset
import androidx.compose.foundation.layout.padding
import androidx.compose.foundation.layout.size
import androidx.compose.foundation.layout.width
import androidx.compose.foundation.shape.RoundedCornerShape
import androidx.compose.material3.Icon
import androidx.compose.material3.IconButton
import androidx.compose.material3.Text
import androidx.compose.runtime.Composable
import androidx.compose.runtime.remember
import androidx.compose.ui.Alignment
import androidx.compose.ui.Modifier
import androidx.compose.ui.draw.clip
Expand Down Expand Up @@ -74,24 +78,33 @@ fun ReviewItem(
modifier = Modifier.fillMaxWidth(),
horizontalAlignment = Alignment.End
) {
IconButton(
onClick = { onMoreClick() }
Box(
modifier = Modifier
.padding(18.dp) // 터치 영역 확장 ( (48 - 12) / 2 )
.offset(x = 18.dp, y = 18.dp) // 시각 위치 되돌리기
.clickable(
onClick = onMoreClick,
indication = null,
interactionSource = remember { MutableInteractionSource() }
)
) {
Comment on lines +81 to 90
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Dec 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

터치 영역을 확장하기 위해 padding과 offset을 조합하여 사용하는 방식은 코드를 이해하기 어렵게 만들고, 의도치 않은 레이아웃 문제를 발생시킬 수 있습니다. 특히 offset(x = 18.dp, y = 18.dp)는 아이콘을 오른쪽 아래로 이동시켜, 주석 // 시각 위치 되돌리기의 의도와 다르게 동작할 가능성이 높습니다.

더 명확하고 관용적인 방법은 Box에 size를 직접 지정하여 터치 영역을 설정하고, contentAlignment를 사용하여 아이콘을 중앙에 배치하는 것입니다. 이 방법은 가독성이 좋고 코드를 유지보수하기 쉽습니다.

Suggested change
Box(
modifier = Modifier
.padding(18.dp) // 터치 영역 확장 ( (48 - 12) / 2 )
.offset(x = 18.dp, y = 18.dp) // 시각 위치 되돌리기
.clickable(
onClick = onMoreClick,
indication = null,
interactionSource = remember { MutableInteractionSource() }
)
) {
Box(
contentAlignment = Alignment.Center,
modifier = Modifier
.size(48.dp) // Material Design 최소 터치 영역
.clickable(
onClick = onMoreClick,
indication = null,
interactionSource = remember { MutableInteractionSource() }
)
) {

Icon(
painter = painterResource(id = R.drawable.ic_menu_12),
contentDescription = "etc",
modifier = Modifier.size(12.dp),
tint = Color.Unspecified,
tint = Color.Unspecified
)
}

Spacer(modifier = Modifier.height(8.dp))

Text(
writeDate,
text = writeDate,
style = EatssuTheme.typography.caption3,
color = Gray400,
modifier = Modifier.padding(end = 20.dp) //20인 이유는 없음 IconButton에 넣으면서 padding 생겨서 끝점을 맞추려고 조절한 것임
color = Gray400
)
}

}

Spacer(modifier = Modifier.height(8.dp))
Expand Down
2 changes: 1 addition & 1 deletion core/design-system/src/main/java/com/eatssu/design_system/component/Chip.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ fun Chip(
Icon(
painter = painterResource(id = R.drawable.ic_thumb_up),
contentDescription = "thumb up Image",
modifier = Modifier.size(16.dp),
modifier = Modifier.size(12.dp),
tint = Primary
)
Spacer(modifier = Modifier.width(4.dp))
Expand Down