-
Notifications
You must be signed in to change notification settings - Fork 20
GATT Database: Remove auth signed write property #88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
GATT Database: Remove auth signed write property #88
Conversation
|
CC @thoh-ot @wopu-ot (please add relevant reviewers) |
This commit removes Authenticated Signed Write property from a characteristic and updates GATT Database hash. The property is removed as the Data signing support is deprecated in Zephyr Bluetooth Host. See corresponding PR for Zephyr. Affected tests: GATT/SR/GPA/BV-04-C GATT/SR/GAR/BV-04-C GATT/SR/GAD/BV-04-C GATT/SR/GAD/BV-05-C Signed-off-by: Pavel Vasilyev <[email protected]>
e1978ed to
0422769
Compare
wopu-ot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can agree with the general approach, but I think a comment is needed to clarify the reason for the change.
| </Descriptors> | ||
| </Characteristic> | ||
| <Characteristic uuid="B011" name="Value V17" handle="176" properties="66" permissions="3">12</Characteristic> | ||
| <Characteristic uuid="B011" name="Value V17" handle="176" properties="2" permissions="3">12</Characteristic> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a comment that this is a deviation from the reference data base that is needed because Zephyr does not support data signing and EDTT does not support an ICS to handle this more elegantly.
|
(no complaints about @wopu-ot request) |
|
Yes, it would be sensible to be more specific regarding the origin of the Excel sheet. Unfortunately, I believe the details of the conversion were lost. I think we could reverse-engineer what was done, but as the source seems to be slow moving (the last changes in GATT Qualification Test Database are from 2015), that will hopefully not be needed any time soon. |
This commit removes Authenticated Signed Write property from a characteristic and updates GATT Database hash.
The property is removed as the Data signing support is deprecated in Zephyr Bluetooth Host. See corresponding PR for Zephyr.
Affected tests:
GATT/SR/GPA/BV-04-C
GATT/SR/GAR/BV-04-C
GATT/SR/GAD/BV-04-C
GATT/SR/GAD/BV-05-C