only respond to bot commands #257
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Neves-P
requested changes
Feb 27, 2024
Member
Neves-P
left a comment
Neves-P
left a comment
There was a problem hiding this comment.
Looks great! Apart from the very small change the CI brings up I can't think of anything else to change. +1 for testing it "in the wild"
eessi_bot_event_handler.py
Outdated
|
|
||
| # check if comment does not contain a bot command | ||
| if not contains_any_bot_command(comment_received): | ||
| self.log(f"comment does not contain a bot comment; not processing it further") |
Member
There was a problem hiding this comment.
No need for an f string here, a plain string will do.
Can't claim credit, the CI clued me in for this one 😉
Neves-P
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This let the bot only respond to comments which contain a bot command. If so it will either process the command if the sender is authorised to send commands to the bot or it will just respond with a note that the sender is not authorised.
The PR has been tested by letting two different accounts (one authorised, one not authorised) send comments with and without bot commands. See comment trz42/software-layer#72 (comment) and below.
The PR essentially adds a new function
contains_any_bot_commandand rearranges the processing inhandle_issue_comment_eventby first checking if the comment was newly created (only newly created comments are considered for processing bot commands), then checking if it contains any bot command, then proceeding with the processing of the commands (incl checking if the sender has permission to send a bot command).