reorganisation of constants and validation of config settings #266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- string constants being used have been defined in the correct modules
- when they are used they have to be prefixed with the module, hence
it becomes more clear to which module they belong
- a new file tools/cvmfs_repository.py for constants used for the settings of a
CernVM-FS repository is added
- both the event handler and job manager verify at the start that
required/recommended settings are defined in 'app.cfg'
Neves-P
requested changes
May 3, 2024
Member
Neves-P
left a comment
Neves-P
left a comment
There was a problem hiding this comment.
Note: I have not run the bot instance on our site with this PR yet, I have only reviewed the code.
I think it's a good change and it adds needed structure for the bot configuration which will make it easier to setup on other sites too! I've just noted a few nitpicking things which could just be me not understanding the logic, go ahead and reject if that's the case.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR turned out to be larger than originally intended (just validating that required config settings are defined when bot components start). However, it reorganises / brings consistent structure to how and where string constants are defined. Hopefully, this makes the code easier to read.
TODO