Optimize checking if PB is disabled for a site #3145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghostwords
force-pushed
the
optimize-disabled-sites
branch
from
d163df7 to
a38a47d
Compare
ghostwords
force-pushed
the
optimize-disabled-sites
branch
from
a38a47d to
df9d437
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1507
It's possible for
disabledSitesin settings storage and the disabled sites trie in memory to get out of sync if we miss updating the trie after adisabledSitesupdate. We might want to subscribe todisabledSiteschanges to avoid this scenario.