Various fixes for devcontainer script #1684
Open
+23
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Get rid of template directory so all necessary devcontainer files are copied. The `devrd` script wasn't being copied when running setupcontainer. 2. Change links to reference everest-core instead of everest-dev-container. 3. Update vscode docs to make sure `./devrd env` is run. Opening the devcontainer in vscode fails if the .env file is missing. Signed-off-by: Aria Nolan <[email protected]>
catarial
requested review from
Pietfried,
SebaLukas,
andistorm,
corneliusclaussen,
djchhp,
hikinggrass,
james-ctc and
mlitre
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the documentation to setup the devcontainer in vscode results in several errors. The devrd script does not get copied when running
setupcontainerand a warning is printed saying it's missing. When opening the devcontainer in vscode it fails to open because the.envfile is missing. It needs to be created with the./devrd envcommand, but that can't be done since the devrd script isn't copied.Describe your changes
devrdscript wasn't being copied when running setupcontainer../devrd envis run. Opening the devcontainer in vscode fails if the .env file is missing.Issue ticket number and link
Checklist before requesting a review