-
-
Notifications
You must be signed in to change notification settings - Fork 27
align toJsonSchemaDocument behavior to toCodecJson #852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
090342b to
212c0ff
Compare
110acaa to
c80ff97
Compare
2ae69c1 to
92e8c4f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This example shows how
Schema.toCodecJsonandSchema.toJsonSchemacan describe the same JSON shape for a custom type.Headersis not JSON-friendly by default.JSON.stringify(new Headers({ a: "b" }))produces{}because the header data is not stored in enumerable properties. By adding atoCodecJsonannotation, you define a JSON-safe representation and use it for both serialization and JSON Schema generation.Example (Align a JSON serializer and JSON Schema for
Headers)