1.20.4

[s-yh-china]

No description provided.

[kpzip]

Looks good for the most part. Is there a reason why you changed the dependency from being just the fabric resource loader to the fabric API as a whole?

[s-yh-china]

just some lazy XD

…

---Original--- From: ***@***.***> Date: Thu, Dec 28, 2023 02:27 AM To: ***@***.***>; Cc: ***@***.******@***.***>; Subject: Re: [End-Tech/syncmatica] 1.20.4 (PR #69) Looks good for the most part. Is there a reason why you changed the dependency from being just the fabric resource loader to the fabric API as a whole? — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: ***@***.***>

[sakura-ryoko]

Generally why my PR only changes the method code, so the maintainers can do the build script and mod version, which basically just remove's the compile warning.

A simple "lazy port" for 1.20.4 would work just fine also; I have tested it weeks ago. 👍
The 1.20.5 snapshot also works just fine so far, using some porting required under malilib and litematica, but nothing that would break syncmatica. 👍

[FlameFire26]

I build from your PR and test with mods:

• fabric-api-0.92.0+1.20.4
• syncmatica-1.20.4-0.3.11-dev

crash-2023-12-28_15.04.18-client.txt

Same crash as I add Malilib and Litematica. Or even disable Fabric API.

[sakura-ryoko]

I build from your PR and test with mods:

Same crash as I add Malilib and Litematica. Or even disable Fabric API.

Which PR did you use ?

[FlameFire26]

Which PR did you use ?

This PR's author @s-yh-china

[s-yh-china]

i will test it, it work in my idea

[sakura-ryoko]

Which PR did you use ?

This PR's author @s-yh-china

I was looking at your log file. Are you running OpenJDK 21 (Azul) ? Perhaps try using JDK 17/18 for Minecraft and then lastly try fabric-api-0.91.1+1.20.4 or fabric-api-0.91.3+1.20.4 .

Nothing @s-yh-china changed should cause this error.

[FlameFire26]

I was looking at your log file. Are you running OpenJDK 21 (Azul) ? Perhaps try using JDK 17/18 for Minecraft and then lastly try fabric-api-0.91.1+1.20.4 or fabric-api-0.91.3+1.20.4 .

I tried both Oracle JDK 17.0.3.1 and Azul JDK 17.0.9, but still crash.
This time only Syncmatica, no Fabric API.
crash-2023-12-28_17.35.24-client.txt

• Adding Malilib and Litematica has no help.
• I was playing well using Azul JDK 21:
  • with 100+ mods with Syncmatica in MC1.20.2
  • with the same mods (have updated from 1.20.2) without Syncmatica in MC1.20.4

[sakura-ryoko]

@FlameFire26 --
Can you try with this build and see if you have the same results ? I am just curious if it has something to do with how you built the jar file.
https://github.com/sakura-ryoko/syncmatica/releases
Its pretty much the same as this PR.

[FlameFire26]

Sorry, I didnt notice that you have built yours.
It seems to work well when I enter world and open Litematica config.

[sakura-ryoko]

Sorry, I didnt notice that you have built yours. It seems to work well when I enter world and open Litematica config.

I usually only do that under the "releases" when I need to test something, so I uploaded it during this conversation for the most part.

[sakura-ryoko]

Perhaps revert this change, and you should be good.

[sakura-ryoko]

I even have a 23w51b working branch if you're interested, but built against my own forks of malilib / litematica that I've been working with masa a bit to help him get them ported without needing to have him focus as much energy on it versus his re-write project, so I also did syncmatica as a downstream mod since 1.20.3-pre.2 .