Skip to content

Conversation

@JackCurragh
Copy link
Member

This is a simple DC update for Beta where we just use a new meta_key/value pair for the sample gene

Copy link
Member

@leannehaggerty leannehaggerty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Jack. LGTM
Just noting that it would be good to extend this check (or create a new one) to make sure the genebuild.sample_location has the correct information - should be a separate PR either way.

Copy link
Contributor

@JAlvarezJarreta JAlvarezJarreta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and the meta key change makes sense.

One thing we were discussing in Plantazoa in the past is the way this sample gene is selected: we were wondering if selecting one from our side at loading time, but then having it reviewed/changed once Compara, Variation and Regulation data is present would be a more meaningful and valuable path to follow for our users. The current set up resulted in some sample genes without Compara data associated with them in the main sites, which is not great IMO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants