Fix/check beta sample location meta value #657
+127
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JAlvarezJarreta
approved these changes
Nov 24, 2025
Contributor
JAlvarezJarreta
left a comment
JAlvarezJarreta
left a comment
There was a problem hiding this comment.
Makes sense to make, thank you for the new DC. Just a couple of comments, nothing major.
| is_rows_zero($self->dba, $sql_2, $desc_2, $diag_2); | ||
|
|
||
| my $desc_3 = 'Sample location coordinates are properly ordered'; | ||
| my $diag_3 = 'genebuild.sample_location start coordinate is greater than end coordinate'; |
Contributor
There was a problem hiding this comment.
Since I'm not too familiar, worth asking: are we always choosing samples/coordinates from the "positive" strand?
Member
Author
There was a problem hiding this comment.
I think that even if the target feature is on reverse strand the the coordinates need to be in this order :-.
I basically just tried flipping them on one example location and the browser complained so I made it a DC.
Co-authored-by: Jorge Alvarez-Jarreta <[email protected]>
Co-authored-by: Jorge Alvarez-Jarreta <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added set of DCs for
genebuild.sample_location