Fix command cooldown bug with case-sensitive commands (#5915) #6361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Normalize command to lowercase for cooldown matching to prevent cooldowns from being applied when commands typed in caps fail to execute. Commands like /EAT or /Eat will now properly match the lowercase cooldown pattern and only apply cooldown when the command successfully executes. Fixes EssentialsX#5915
JRoy
requested changes
Nov 16, 2025
Member
JRoy
left a comment
JRoy
left a comment
There was a problem hiding this comment.
This does not fix the bug described. The issue is that command may only be lowercase and thus do not execute when you use caps in them, but we still count cooldown on those commands.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a bug where command cooldowns were being applied even when commands typed in different cases (e.g.,
/EAT,/Eat) failed to execute.Changes
fullCommandstring to lowercase inEssentialsPlayerListener.handlePlayerCommandPreprocess()to ensure case-insensitive cooldown matchingTesting
/eat,/EAT,/Eatnow all properly share the same cooldown timerFixes #5915