fix: potential memory pressure on server side #372
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fix changes the default configuration of the HTTP/2 transport to advertise an unlimited value to the peer for SETTINGS_MAX_HEADER_LIST_SIZE (0x6). This configuration basically disables sending the setting at all. So the server uses its default settings. As some servers like Jetty allocate buffers in size of this setting, this can lead to memory pressure or even OOM errors when the server is not configured properly. see https://www.ietf.org/archive/id/draft-ietf-httpbis-http2bis-07.html#section-6.5.2-2.11
Contributor
Author
|
@nikos912000 Could you review my small changes? Additional tests for this configuration would require a different test server strategy to check the SETTINGS frame. So i avoided it for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
This fix changes the default configuration of the HTTP/2 transport to advertise an unlimited value to the peer for SETTINGS_MAX_HEADER_LIST_SIZE (0x6). This configuration basically disables sending the setting at all. So the server uses its default settings.
As some servers like Jetty allocate buffers in size of this setting, this can lead to memory pressure or even OOM errors when the server is not configured properly.
see https://www.ietf.org/archive/id/draft-ietf-httpbis-http2bis-07.html#section-6.5.2-2.11
🔗 Related Issues
#371