-
Notifications
You must be signed in to change notification settings - Fork 3
add multireference quantum chemistry #307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Pull Request Test Coverage Report for Build 20433944122Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 9 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.
Comments suppressed due to low confidence (1)
src/nomad_simulations/utils/mo_cube.py:13
- Import of 'Optional' is not used.
from typing import Optional
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Purpose
Adds multireference quantum-chemistry related extensions to the schema.
Since these methods are only well defined in the presence of a defined active orbital space, this PR also introduces two utility modules demonstrating how
MolecularOrbitalscan be integrated and referenced at the schema level.This paves the way for future GUI implementations to include a visualization for active molecular orbitals.
Scope
ActiveSpaceschema section to describe the active orbital and electron subspace used by multireference methods. This base is designed to be used by all downstream methods as a subsection.BaseMultireferenceMethodwhich includes share method parameters.MultireferenceSCF,MultireferenceCI,MultireferencePT, to further group the methods.utils/mo_cube.py,utils/mo_trexio.pyand their corresponding unit tests.Out of scope (What is explicitly not included (to avoid scope creep)?)
numerical_settings.pyThe current PR only involves the method descriptions for each step.
Status
Select one
Dependencies / Blockers
List anything that may block progress or review
Testing / Validation
How was this change validated?
I have added a set of example uploads to
nomad-simulation-examples, to showcase the parsed archives.Linked Issues / Context
Use GitHub keywords where applicable.
Context & Links
For more context, I have created a summary file in simple English to navigate reviewers better:
Reviewer Notes