memory benchmark added to github actions #317
Open
+51
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vlado Lavor <[email protected]>
| if !pass { | ||
| b.Fatal("one or more memory thresholds was exceeded") | ||
| b.Errorf("one or more memory thresholds was exceeded") | ||
| b.FailNow() |
Member
There was a problem hiding this comment.
There was a problem hiding this comment.
I'd say none, I was just trying to see if GA thinks the same
.
The thing is that the github workflow passes even if the test fails, for example
--- FAIL: BenchmarkAPIMemory
memory_api_test.go:158: one or more memory thresholds was exceeded
vpptest.go:225: VPP stopped
FAIL
exit status 1
FAIL go.fd.io/govpp/test/memory 287.375s
FAILED! (exit code: 1)
In https://github.com/FDio/govpp/actions/runs/18878245769/job/53873795524
But the workflow is marked green.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.