Skip to content

Conversation

@ChengZhiMeow
Copy link
Contributor

@ChengZhiMeow ChengZhiMeow commented Nov 17, 2025

πŸ“‹ Description

This PR fixes a critical bug where executing the /fancyholograms reload command in certain situations causes all holograms to disappear and not be reloaded.

βœ… Checklist

  • My code follows the project's coding style and guidelines
  • I have tested my changes locally and they work as expected
  • I have added necessary documentation (if applicable)
  • I have linked related issues using Fixes #issue_number or Closes #issue_number
  • I have rebased/merged with the latest main branch

πŸ” Changes

  • Fixed reload cannot load hologram

πŸ§ͺ How to Test

  1. Install the plugin and start the server.
  2. Create a hologram
  3. Execute the reload command: /fancyholograms reload.

Copy link
Member

@OliverSchlueter OliverSchlueter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@OliverSchlueter OliverSchlueter merged commit 529821c into FancyInnovations:main Nov 21, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants