Skip to content

Conversation

@ssquadteam
Copy link
Contributor

@ssquadteam ssquadteam commented Nov 19, 2025

📋 Description

We were plagued with performance issues so we decided to Fork it and implement the below mentioned changes which helped BY A LOT

✅ Checklist

  • [✅] My code follows the project's coding style and guidelines
  • [✅] I have tested my changes locally and they work as expected
  • [Not Applicable] I have added necessary documentation (if applicable)
  • [Not Applicable] I have linked related issues using Fixes #issue_number or Closes #issue_number
  • [✅] I have rebased/merged with the latest main branch

🔍 Changes

Please provide a brief summary of the changes made in this PR.

  • Implemented caching for hologram text update using Guava Cache for improved performance
  • Made it so it Caches entity data accessors to reduce reflection overhead

🧪 How to Test

Please describe how to manually test the changes made in this PR.

  1. Just Spin it up in a Server with large Player counts, w/ many Holograms with Placeholders and so on

Below are Spark References-

Before

image

After

image

First was taken with 400-500 on
The After was taken with 600+ on

@Grabsky
Copy link
Contributor

Grabsky commented Nov 25, 2025

Concept and general impl looks good. Code review from @OliverSchlueter is still pending but I'm excited to see these changes. Thank you!

Fixes #119

Copy link
Member

@OliverSchlueter OliverSchlueter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you! I'll merge it once the next version of FancyHolograms is released (right after 1.21.11 is out), so it's in dev builds a bit longer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants