Skip to content

Conversation

@silent-cipher
Copy link
Collaborator

@silent-cipher silent-cipher commented Apr 28, 2025

Features:

  • Fully functional Subgraph ready to be deployed on mainnet and calibnet
  • ready to use subgraph gql apis client
  • Documentation to deploy their own subgraph and run the client. It also covers how you can update it for your own use cases if needed.

Also, fixes #65

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request introduces a new subgraph and accompanying client for interacting with PDP data across mainnet and calibration networks. Key changes include:

  • Added React components to display recent providers, recent proof sets, and network stats.
  • Introduced an API service module to query the subgraph.
  • Included project configuration files (Prettier, ESLint, PostCSS), a main application entry point, and detailed deployment documentation.

Reviewed Changes

Copilot reviewed 89 out of 99 changed files in this pull request and generated no comments.

Show a summary per file
File Description
subgraph-client/src/components/Landing/RecentProvidersTable.tsx Table component displaying recent providers.
subgraph-client/src/components/Landing/RecentProofSetsTable.tsx Table component displaying recent proof sets.
subgraph-client/src/components/Landing/NetworkStatsCard.tsx Card component showing network metrics with a computed PDP proofs value.
subgraph-client/src/api/apiService.ts API service for fetching providers and proof sets from the subgraph.
subgraph-client/src/App.tsx Main application entry point setting up routes and notifications.
subgraph-client/prettier.config.js Prettier configuration for code formatting.
subgraph-client/postcss.config.js PostCSS configuration for TailwindCSS and autoprefixer.
subgraph-client/index.html HTML template with meta tags for SEO and social sharing.
subgraph-client/.eslintrc.cjs ESLint configuration tailored for the project.
docs/subgraph/deployment.md Documentation detailing subgraph deployment and client usage.
Files not reviewed (10)
  • subgraph-client/.env.example: Language not supported
  • subgraph-client/.gitignore: Language not supported
  • subgraph-client/.prettierignore: Language not supported
  • subgraph-client/.prettierrc: Language not supported
  • subgraph-client/Dockerfile: Language not supported
  • subgraph-client/components.json: Language not supported
  • subgraph-client/package.json: Language not supported
  • subgraph-client/public/robots.txt: Language not supported
  • subgraph-client/public/site.webmanifest: Language not supported
  • subgraph-client/public/sitemap.xml: Language not supported
Comments suppressed due to low confidence (1)

subgraph-client/src/components/Landing/NetworkStatsCard.tsx:71

  • [nitpick] Consider extracting the magic number '5' into a named constant or configuration value for improved clarity and maintainability.
value={(Number(metrics.totalProofs) * 5).toLocaleString()}

@jennijuju
Copy link

any reason why we shouldnt merge this?

@silent-cipher
Copy link
Collaborator Author

@jennijuju now there doesn't seem any reason.

@rjan90 rjan90 requested a review from aarshkshah1992 June 6, 2025 10:18
@rjan90 rjan90 added this to PDP Jun 12, 2025
@rjan90 rjan90 moved this to 🔎 Awaiting review in PDP Jun 12, 2025
Copy link
Contributor

@ZenGround0 ZenGround0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI I'm not looking at this too closely. Nothing seems obviously wrong.

@jennijuju
Copy link

should we land this to main? @kaola526

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🔎 Awaiting review

Development

Successfully merging this pull request may close these issues.

List all the service contract that uses the canonical PDP verifier

6 participants