-
Notifications
You must be signed in to change notification settings - Fork 4
Feat: Add PDP Subgraph and subgraph client #63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request introduces a new subgraph and accompanying client for interacting with PDP data across mainnet and calibration networks. Key changes include:
- Added React components to display recent providers, recent proof sets, and network stats.
- Introduced an API service module to query the subgraph.
- Included project configuration files (Prettier, ESLint, PostCSS), a main application entry point, and detailed deployment documentation.
Reviewed Changes
Copilot reviewed 89 out of 99 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| subgraph-client/src/components/Landing/RecentProvidersTable.tsx | Table component displaying recent providers. |
| subgraph-client/src/components/Landing/RecentProofSetsTable.tsx | Table component displaying recent proof sets. |
| subgraph-client/src/components/Landing/NetworkStatsCard.tsx | Card component showing network metrics with a computed PDP proofs value. |
| subgraph-client/src/api/apiService.ts | API service for fetching providers and proof sets from the subgraph. |
| subgraph-client/src/App.tsx | Main application entry point setting up routes and notifications. |
| subgraph-client/prettier.config.js | Prettier configuration for code formatting. |
| subgraph-client/postcss.config.js | PostCSS configuration for TailwindCSS and autoprefixer. |
| subgraph-client/index.html | HTML template with meta tags for SEO and social sharing. |
| subgraph-client/.eslintrc.cjs | ESLint configuration tailored for the project. |
| docs/subgraph/deployment.md | Documentation detailing subgraph deployment and client usage. |
Files not reviewed (10)
- subgraph-client/.env.example: Language not supported
- subgraph-client/.gitignore: Language not supported
- subgraph-client/.prettierignore: Language not supported
- subgraph-client/.prettierrc: Language not supported
- subgraph-client/Dockerfile: Language not supported
- subgraph-client/components.json: Language not supported
- subgraph-client/package.json: Language not supported
- subgraph-client/public/robots.txt: Language not supported
- subgraph-client/public/site.webmanifest: Language not supported
- subgraph-client/public/sitemap.xml: Language not supported
Comments suppressed due to low confidence (1)
subgraph-client/src/components/Landing/NetworkStatsCard.tsx:71
- [nitpick] Consider extracting the magic number '5' into a named constant or configuration value for improved clarity and maintainability.
value={(Number(metrics.totalProofs) * 5).toLocaleString()}
|
any reason why we shouldnt merge this? |
|
@jennijuju now there doesn't seem any reason. |
ZenGround0
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI I'm not looking at this too closely. Nothing seems obviously wrong.
|
should we land this to main? @kaola526 |
Features:
Also, fixes #65