Skip to content

Conversation

@mpustovoi
Copy link

@mpustovoi mpustovoi commented May 1, 2024

Both Sodium and Embeddium lang folders
Most of the translations for the Sodium folder are provided by the Translations for Sodium resource pack

mpustovoi added 2 commits May 1, 2024 21:25
`Sodium` lang folder
`Embeddium` lang folder
@github-actions
Copy link

github-actions bot commented May 1, 2024

DCO Assistant Lite bot All contributors have read and affirmed the entire contents of the Developer Certificate of Origin.

@mpustovoi
Copy link
Author

I have read, and hereby affirm the entire contents of the Developer Certificate of Origin.

Copy link
Contributor

@embeddedt embeddedt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The strings in the sodium/lang file need to mention Embeddium (even though the key is still sodium), except for sodium.options.buttons.donate. That one should be left as-is.

@mpustovoi mpustovoi requested a review from embeddedt May 1, 2024 18:56
Copy link
Contributor

@embeddedt embeddedt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. We are still sorting out how we want to handle the logistics of translations for the original Sodium strings going forward, hence the delay in merging.

Added new lines.
@rikzun
Copy link

rikzun commented Aug 1, 2025

BRUH

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants